Merge pull request rails#45645 from fatkodima/fix-store-dirty

Updating the `ActiveRecord::Store` and changing it back should not mark accessor as changed

Author: byroot

activerecord/lib/active_record/store.rb

@@ -225,10 +225,7 @@ def self.read(object, attribute, key)
 
         def self.write(object, attribute, key, value)
           prepare(object, attribute)
-          if value != read(object, attribute, key)
-            object.public_send :"#{attribute}_will_change!"
-            object.public_send(attribute)[key] = value
-          end
+          object.public_send(attribute)[key] = value
         end
 
         def self.prepare(object, attribute)

activerecord/test/cases/store_test.rb

@@ -104,6 +104,14 @@ class StoreTest < ActiveRecord::TestCase
     assert_not @john.color_changed?
   end
 
+  test "updating the store and changing it back won't mark accessor as changed" do
+    @john.color = "red"
+    assert_equal "black", @john.color_was
+    @john.color = "black"
+    assert_not_predicate @john, :settings_changed?
+    assert_not_predicate @john, :color_changed?
+  end
+
   test "updating the store populates the accessor changed array correctly" do
     @john.color = "red"
     assert_equal "black", @john.color_was