Merge pull request rails#46186 from Shopify/remove-transaction-joinable-from-doc

byroot · web-flow · commit 6d0bafaa668b · 2022-10-04T09:56:50.000+02:00
Remove private `transaction(joinable:)` parameter from RDoc
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb
@@ -306,6 +306,7 @@ def truncate_tables(*table_names) # :nodoc:
       #
       # The mysql2 and postgresql adapters support setting the transaction
       # isolation level.
+      #  :args: (requires_new: nil, isolation: nil, &block)
       def transaction(requires_new: nil, isolation: nil, joinable: true, &block)
         if !requires_new && current_transaction.joinable?
           if isolation

Original file line number	Diff line number	Diff line change
`@@ -306,6 +306,7 @@ def truncate_tables(*table_names) # :nodoc:`
`306`	`306`	`#`
`307`	`307`	`# The mysql2 and postgresql adapters support setting the transaction`
`308`	`308`	`# isolation level.`
	`309`	`+ # :args: (requires_new: nil, isolation: nil, &block)`
`309`	`310`	`def transaction(requires_new: nil, isolation: nil, joinable: true, &block)`
`310`	`311`	`if !requires_new && current_transaction.joinable?`
`311`	`312`	`if isolation`