Add column types to ActiveRecord::Result for SQLite3

Author: ankane

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Add column types to `ActiveRecord::Result` for SQLite3.
+
+    *Andrew Kane*
+
 *   Raise `ActiveRecord::ReadOnlyError` when pessimistically locking with a readonly role.
 
     *Joshua Young*

activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb

@@ -87,7 +87,11 @@ def perform_query(raw_connection, sql, binds, type_casted_binds, prepare:, notif
                 stmt.step
                 ActiveRecord::Result.empty
               else
-                ActiveRecord::Result.new(stmt.columns, stmt.to_a)
+                types = {}
+                stmt.columns.zip(stmt.types).each_with_index do |(c, t), i|
+                  types[c] = types[i] = type_map.lookup(t)
+                end
+                ActiveRecord::Result.new(stmt.columns, stmt.to_a, types.freeze)
               end
             else
               # Don't cache statements if they are not prepared.
@@ -100,7 +104,11 @@ def perform_query(raw_connection, sql, binds, type_casted_binds, prepare:, notif
                   stmt.step
                   ActiveRecord::Result.empty
                 else
-                  ActiveRecord::Result.new(stmt.columns, stmt.to_a)
+                  types = {}
+                  stmt.columns.zip(stmt.types).each_with_index do |(c, t), i|
+                    types[c] = types[i] = type_map.lookup(t)
+                  end
+                  ActiveRecord::Result.new(stmt.columns, stmt.to_a, types.freeze)
                 end
               ensure
                 stmt.close

activerecord/test/cases/base_test.rb

@@ -1688,6 +1688,18 @@ def test_column_types_on_queries_on_postgresql
     end
   end
 
+  if current_adapter?(:SQLite3Adapter)
+    def test_column_types_on_queries_on_sqlite
+      result = ActiveRecord::Base.lease_connection.exec_query("SELECT id, last_read, created_at FROM topics")
+      assert_equal ActiveRecord::ConnectionAdapters::SQLite3Adapter::SQLite3Integer, result.column_types["id"].class
+      assert_equal ActiveRecord::Type::Date, result.column_types["last_read"].class
+      assert_equal ActiveRecord::Type::DateTime, result.column_types["created_at"].class
+      assert_equal result.column_types[0], result.column_types["id"]
+      assert_equal result.column_types[1], result.column_types["last_read"]
+      assert_equal result.column_types[2], result.column_types["created_at"]
+    end
+  end
+
   def test_typecasting_aliases
     assert_equal 10, Topic.select("10 as tenderlove").first.tenderlove
   end