Merge pull request rails#43687 from ghiculescu/patch-6

eileencodes · web-flow · commit 6e1694275007 · 2021-11-22T10:50:11.000-05:00
Add warning about `type` arg in `column_exists?`
diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
@@ -124,6 +124,9 @@ def columns(table_name)
       #   column_exists?(:suppliers, :name)
       #
       #   # Check a column exists of a particular type
+      #   #
+      #   # This works for standard non-casted types (eg. string) but is unreliable
+      #   # for types that may get chasted (eg. char).
       #   column_exists?(:suppliers, :name, :string)
       #
       #   # Check a column exists with a specific definition

Original file line number	Diff line number	Diff line change
`@@ -124,6 +124,9 @@ def columns(table_name)`
`124`	`124`	`# column_exists?(:suppliers, :name)`
`125`	`125`	`#`
`126`	`126`	`# # Check a column exists of a particular type`
	`127`	`+ # #`
	`128`	`+ # # This works for standard non-casted types (eg. string) but is unreliable`
	`129`	`+ # # for types that may get chasted (eg. char).`
`127`	`130`	`# column_exists?(:suppliers, :name, :string)`
`128`	`131`	`#`
`129`	`132`	`# # Check a column exists with a specific definition`