More feedback

Author: adrianna-chang-shopify

activesupport/lib/active_support/event_reporter.rb

@@ -192,7 +192,7 @@ def clear
   #
   # Context is reset automatically before and after each request.
   #
-  # A custom context store can be configured via `config.active_support.event_reporter_context_store`.
+  # A custom context store can be configured via +config.active_support.event_reporter_context_store+.
   #
   #     # config/application.rb
   #     config.active_support.event_reporter_context_store = CustomContextStore

activesupport/lib/active_support/event_reporter/encoders.rb

@@ -17,10 +17,11 @@ class EventReporter
     #     end
     #   end
     #
+    #   Rails.event.subscribe(LogSubscriber)
     module Encoders
-      # Base encoder class that other encoders can inherit from
+      # Base encoder class that other encoders can inherit from.
       class Base
-        # Encodes an event hash into a serialized format
+        # Encodes an event hash into a serialized format.
         #
         # @param event [Hash] The event hash containing name, payload, tags, context, timestamp, and source_location
         # @return [String] The encoded event data
@@ -72,6 +73,7 @@ def self.encode(event)
         end
       end
 
+      # EventReporter encoder for serializing events to MessagePack format.
       class MessagePack < Base
         def self.encode(event)
           require "msgpack"

activesupport/lib/active_support/event_reporter/test_helper.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module ActiveSupport::EventReporter::TestHelper # :nodoc:
-  class EventSubscriber
+  class EventSubscriber # :nodoc:
     attr_reader :events
 
     def initialize

activesupport/lib/active_support/railtie.rb

@@ -42,10 +42,12 @@ class Railtie < Rails::Railtie # :nodoc:
       app.reloader.before_class_unload do
         ActiveSupport::CurrentAttributes.clear_all
         ActiveSupport::ExecutionContext.clear
+        ActiveSupport.event_reporter.clear_context
       end
 
       app.executor.to_run do
         ActiveSupport::ExecutionContext.push
+        ActiveSupport.event_reporter.clear_context
       end
 
       app.executor.to_complete do
@@ -69,11 +71,6 @@ class Railtie < Rails::Railtie # :nodoc:
       end
     end
 
-    initializer "active_support.reset_event_reporter_context" do |app|
-      app.reloader.before_class_unload { ActiveSupport.event_reporter.clear_context }
-      app.executor.to_run              { ActiveSupport.event_reporter.clear_context }
-    end
-
     initializer "active_support.deprecation_behavior" do |app|
       if app.config.active_support.report_deprecations == false
         app.deprecators.silenced = true

activesupport/lib/active_support/testing/event_reporter_assertions.rb

@@ -5,11 +5,11 @@ module ActiveSupport
   module Testing
     # Provides test helpers for asserting on ActiveSupport::EventReporter events.
     module EventReporterAssertions
-      module EventCollector # :nodoc: all
+      module EventCollector # :nodoc:
         @subscribed = false
         @mutex = Mutex.new
 
-        class Event
+        class Event # :nodoc:
           attr_reader :event_data
 
           def initialize(event_data)