Skip to content

Commit 721a392

Browse files
committed
Consolidate two if column_name == :all conditions
1 parent df99121 commit 721a392

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

activerecord/lib/active_record/relation/calculations.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -656,6 +656,7 @@ def build_count_subquery(relation, column_name, distinct)
656656
if column_name == :all
657657
column_alias = Arel.star
658658
relation.select_values = [ Arel.sql(FinderMethods::ONE_AS_ONE) ] unless distinct
659+
relation.unscope!(:order)
659660
else
660661
column_alias = Arel.sql("count_column")
661662
relation.select_values = [ aggregate_column(column_name).as(column_alias) ]
@@ -664,11 +665,7 @@ def build_count_subquery(relation, column_name, distinct)
664665
subquery_alias = Arel.sql("subquery_for_count", retryable: true)
665666
select_value = operation_over_aggregate_column(column_alias, "count", false)
666667

667-
if column_name == :all
668-
relation.unscope(:order).build_subquery(subquery_alias, select_value)
669-
else
670-
relation.build_subquery(subquery_alias, select_value)
671-
end
668+
relation.build_subquery(subquery_alias, select_value)
672669
end
673670
end
674671
end

0 commit comments

Comments
 (0)