Skip to content

Commit 7479485

Browse files
Add ActiveModel.deprecator
This commit adds `ActiveModel.deprecator`, and adds it to `Rails.application.deprecators` so that it can be configured via settings such as `config.active_support.report_deprecations`.
1 parent b2bc006 commit 7479485

File tree

5 files changed

+14
-1
lines changed

5 files changed

+14
-1
lines changed

activemodel/lib/active_model.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
require "active_support"
2727
require "active_support/rails"
2828
require "active_model/version"
29+
require "active_model/deprecator"
2930

3031
module ActiveModel
3132
extend ActiveSupport::Autoload
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# frozen_string_literal: true
2+
3+
module ActiveModel
4+
def self.deprecator # :nodoc:
5+
@deprecator ||= ActiveSupport::Deprecation.new
6+
end
7+
end

activemodel/lib/active_model/railtie.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ class Railtie < Rails::Railtie # :nodoc:
99

1010
config.active_model = ActiveSupport::OrderedOptions.new
1111

12+
initializer "active_model.deprecator" do |app|
13+
app.deprecators[:active_model] = ActiveModel.deprecator
14+
end
15+
1216
initializer "active_model.secure_password" do
1317
ActiveModel::SecurePassword.min_cost = Rails.env.test?
1418
end

activemodel/test/cases/helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
require "active_model"
55

66
# Show backtraces for deprecated behavior for quicker cleanup.
7-
ActiveSupport::Deprecation.debug = true
7+
ActiveModel.deprecator.debug = true
88

99
# Disable available locale checks to avoid warnings running the test suite.
1010
I18n.enforce_available_locales = false

railties/test/application/configuration_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3898,6 +3898,7 @@ def new(app); self; end
38983898
assert_equal ActionText.deprecator, Rails.application.deprecators[:action_text]
38993899
assert_equal ActionView.deprecator, Rails.application.deprecators[:action_view]
39003900
assert_equal ActiveJob.deprecator, Rails.application.deprecators[:active_job]
3901+
assert_equal ActiveModel.deprecator, Rails.application.deprecators[:active_model]
39013902
assert_equal ActiveRecord.deprecator, Rails.application.deprecators[:active_record]
39023903
assert_equal ActiveStorage.deprecator, Rails.application.deprecators[:active_storage]
39033904
assert_equal ActiveSupport.deprecator, Rails.application.deprecators[:active_support]

0 commit comments

Comments
 (0)