Skip inflector when generating HTTP_METHOD_LOOKUP

skipkayhil · skipkayhil · commit 7bc0976cc0a6 · 2025-01-28T22:31:05.000-05:00
HTTP_METHOD_LOOKUP's creation was recently updated to explicitly use
`downcase` since an application's custom inflections could previously
affect it. However, `underscore` is still present even though the only
transformation needed after `downcase` is substituting `-` for `_`.

Since `underscore` is overkill in this case, this commit replaces it
with `tr!`.
diff --git a/actionpack/lib/action_dispatch/http/request.rb b/actionpack/lib/action_dispatch/http/request.rb
@@ -138,7 +138,7 @@ def key?(key)
 
     # Populate the HTTP method lookup cache.
     HTTP_METHODS.each { |method|
-      HTTP_METHOD_LOOKUP[method] = method.downcase.underscore.to_sym
+      HTTP_METHOD_LOOKUP[method] = method.downcase.tap { |m| m.tr!("-", "_") }.to_sym
     }
 
     alias raw_request_method request_method # :nodoc:

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ def key?(key)`
`138`	`138`
`139`	`139`	`# Populate the HTTP method lookup cache.`
`140`	`140`	`HTTP_METHODS.each { \|method\|`
`141`		`- HTTP_METHOD_LOOKUP[method] = method.downcase.underscore.to_sym`
	`141`	`+ HTTP_METHOD_LOOKUP[method] = method.downcase.tap { \|m\| m.tr!("-", "_") }.to_sym`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`alias raw_request_method request_method # :nodoc:`