Skip to content

Commit 8819ab5

Browse files
committed
Support selenium-webdriver 4.32.0
This pull request supports selenium-webdriver 4.32.0 that sets remote.active-protocols => 1 via SeleniumHQ/selenium@a1ff120a9fd - Steps to reproduce and this commit fixes these two failures: ``` $ bundle update selenium-webdriver --conservative ... snip ... $ git diff diff --git a/Gemfile.lock b/Gemfile.lock index db3f0d1..07f40b9 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -574,7 +574,7 @@ GEM sass-embedded (1.83.4-x86_64-linux-musl) google-protobuf (~> 4.29) securerandom (0.4.1) - selenium-webdriver (4.29.1) + selenium-webdriver (4.32.0) base64 (~> 0.2) logger (~> 1.4) rexml (~> 3.2, >= 3.2.5) $ bin/test test/dispatch/system_testing/driver_test.rb -n '/^test_define_extra_capabilities_using_(headless_)?firefox$/' ... snip ... F Failure: DriverTest#test_define_extra_capabilities_using_firefox [test/dispatch/system_testing/driver_test.rb:128]: --- expected +++ actual @@ -1 +1 @@ -{"moz:firefoxOptions" => {"args" => ["--host=127.0.0.1"], "prefs" => {"remote.active-protocols" => 3, "browser.startup.homepage" => "http://www.seleniumhq.com/"}}, "browserName" => "firefox"} +{"moz:firefoxOptions" => {"args" => ["--host=127.0.0.1"], "prefs" => {"remote.active-protocols" => 1, "browser.startup.homepage" => "http://www.seleniumhq.com/"}}, "browserName" => "firefox"} bin/test test/dispatch/system_testing/driver_test.rb:114 F Failure: DriverTest#test_define_extra_capabilities_using_headless_firefox [test/dispatch/system_testing/driver_test.rb:145]: --- expected +++ actual @@ -1 +1 @@ -{"moz:firefoxOptions" => {"args" => ["-headless", "--host=127.0.0.1"], "prefs" => {"remote.active-protocols" => 3, "browser.startup.homepage" => "http://www.seleniumhq.com/"}}, "browserName" => "firefox"} +{"moz:firefoxOptions" => {"args" => ["-headless", "--host=127.0.0.1"], "prefs" => {"remote.active-protocols" => 1, "browser.startup.homepage" => "http://www.seleniumhq.com/"}}, "browserName" => "firefox"} bin/test test/dispatch/system_testing/driver_test.rb:131 Finished in 0.009594s, 208.4566 runs/s, 208.4566 assertions/s. 2 runs, 2 assertions, 2 failures, 0 errors, 0 skips $ ```
1 parent e0bfbb2 commit 8819ab5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ GEM
574574
sass-embedded (1.83.4-x86_64-linux-musl)
575575
google-protobuf (~> 4.29)
576576
securerandom (0.4.1)
577-
selenium-webdriver (4.29.1)
577+
selenium-webdriver (4.32.0)
578578
base64 (~> 0.2)
579579
logger (~> 1.4)
580580
rexml (~> 3.2, >= 3.2.5)

actionpack/test/dispatch/system_testing/driver_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ class DriverTest < ActiveSupport::TestCase
121121
expected = {
122122
"moz:firefoxOptions" => {
123123
"args" => ["--host=127.0.0.1"],
124-
"prefs" => { "remote.active-protocols" => 3, "browser.startup.homepage" => "http://www.seleniumhq.com/" }
124+
"prefs" => { "remote.active-protocols" => 1, "browser.startup.homepage" => "http://www.seleniumhq.com/" }
125125
},
126126
"browserName" => "firefox"
127127
}
@@ -138,7 +138,7 @@ class DriverTest < ActiveSupport::TestCase
138138
expected = {
139139
"moz:firefoxOptions" => {
140140
"args" => ["-headless", "--host=127.0.0.1"],
141-
"prefs" => { "remote.active-protocols" => 3, "browser.startup.homepage" => "http://www.seleniumhq.com/" }
141+
"prefs" => { "remote.active-protocols" => 1, "browser.startup.homepage" => "http://www.seleniumhq.com/" }
142142
},
143143
"browserName" => "firefox"
144144
}

0 commit comments

Comments
 (0)