Avoid uninitialized variable warnings on Ruby 2.7

byroot · byroot · commit 890015ae46ad · 2022-10-03T21:29:19.000+02:00
Since the variable is either set to true, or not present at all
we can check wether it's defined instead.
diff --git a/activesupport/lib/active_support/error_reporter.rb b/activesupport/lib/active_support/error_reporter.rb
@@ -166,7 +166,7 @@ def set_context(...)
     #   Rails.error.report(error)
     #
     def report(error, handled: true, severity: handled ? :warning : :error, context: {}, source: DEFAULT_SOURCE)
-      return if error.instance_variable_get(:@__rails_error_reported)
+      return if error.instance_variable_defined?(:@__rails_error_reported)
 
       unless SEVERITIES.include?(severity)
         raise ArgumentError, "severity must be one of #{SEVERITIES.map(&:inspect).join(", ")}, got: #{severity.inspect}"

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ def set_context(...)`
`166`	`166`	`# Rails.error.report(error)`
`167`	`167`	`#`
`168`	`168`	`def report(error, handled: true, severity: handled ? :warning : :error, context: {}, source: DEFAULT_SOURCE)`
`169`		`- return if error.instance_variable_get(:@__rails_error_reported)`
	`169`	`+ return if error.instance_variable_defined?(:@__rails_error_reported)`
`170`	`170`
`171`	`171`	`unless SEVERITIES.include?(severity)`
`172`	`172`	`raise ArgumentError, "severity must be one of #{SEVERITIES.map(&:inspect).join(", ")}, got: #{severity.inspect}"`