Skip to content

Commit 896f6dd

Browse files
Pin GitHub Actions versions (rails#55147)
* Pin GitHub Actions versions After recent [supply chain attacks](https://www.bleepingcomputer.com/news/security/github-action-hack-likely-led-to-another-in-cascading-supply-chain-attack/) on widely used GitHub Actions, it is now [security best practice](https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions) to pin GitHub Actions versions in workflow files. This PR makes that change, using the latest versions that the current major versions in code imply. * Revert "Pin GitHub Actions versions" This reverts commit 490bfb7. * Change to only specifying the SHA for non-well-known sources * Change to only specifying the SHA for non-well-known sources Co-authored-by: Rafael Mendonça França <[email protected]>
1 parent 7d2e133 commit 896f6dd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/devcontainer-smoke-test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
uses: actions/checkout@v4
1919

2020
- name: Login to GitHub Container Registry
21-
uses: docker/login-action@v3
21+
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
2222
with:
2323
registry: ghcr.io
2424
username: ${{ github.repository_owner }}
@@ -34,7 +34,7 @@ jobs:
3434
run: bundle exec railties/exe/rails new myapp_sqlite --database="sqlite3" --dev --devcontainer
3535

3636
- name: Test devcontainer sqlite3
37-
uses: devcontainers/[email protected]
37+
uses: devcontainers/ci@8bf61b26e9c3a98f69cb6ce2f88d24ff59b785c6 # v0.3.1900000417
3838
with:
3939
subFolder: myapp_sqlite
4040
imageName: ghcr.io/rails/smoke-test-devcontainer
@@ -51,7 +51,7 @@ jobs:
5151
run: bundle exec railties/exe/rails new myapp_postgresql --database="postgresql" --dev --devcontainer
5252

5353
- name: Test devcontainer postgresql
54-
uses: devcontainers/[email protected]
54+
uses: devcontainers/ci@8bf61b26e9c3a98f69cb6ce2f88d24ff59b785c6 # v0.3.1900000417
5555
with:
5656
subFolder: myapp_postgresql
5757
imageName: ghcr.io/rails/smoke-test-devcontainer
@@ -68,7 +68,7 @@ jobs:
6868
run: bundle exec railties/exe/rails new myapp_mysql --database="mysql" --dev --devcontainer
6969

7070
- name: Test devcontainer mysql
71-
uses: devcontainers/[email protected]
71+
uses: devcontainers/ci@8bf61b26e9c3a98f69cb6ce2f88d24ff59b785c6 # v0.3.1900000417
7272
with:
7373
subFolder: myapp_mysql
7474
imageName: ghcr.io/rails/smoke-test-devcontainer
@@ -85,7 +85,7 @@ jobs:
8585
run: bundle exec railties/exe/rails new myapp_trilogy --database="trilogy" --dev --devcontainer
8686

8787
- name: Test devcontainer trilogy
88-
uses: devcontainers/[email protected]
88+
uses: devcontainers/ci@8bf61b26e9c3a98f69cb6ce2f88d24ff59b785c6 # v0.3.1900000417
8989
with:
9090
subFolder: myapp_trilogy
9191
imageName: ghcr.io/rails/smoke-test-devcontainer

.github/workflows/rails-new-docker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
- name: Test container
4242
run: ruby -r ./.github/workflows/scripts/test-container.rb
4343

44-
- uses: zzak/action-discord@v8
44+
- uses: zzak/action-discord@4cd181470664aa174b7252e5afb2ecf896001817 # v8
4545
continue-on-error: true
4646
if: failure() && github.ref_name == 'main'
4747
with:

0 commit comments

Comments
 (0)