Use in_memory_db? test helper

Author: byroot

activerecord/test/cases/migration/foreign_key_test.rb

@@ -554,37 +554,33 @@ def test_schema_dumping_with_defferable_initially_immediate
           end
         end
 
-        def test_does_not_create_foreign_keys_when_bypassed_by_config
-          if current_adapter?(:SQLite3Adapter) && !ActiveRecord::Base.connection.supports_concurrent_connections?
-            skip("Can't reopen in-memory database")
-          else
-            begin
-              connection = ActiveRecord::Base.establish_connection(
-                {
-                  adapter: "sqlite3",
-                  database: "test/db/test.sqlite3",
-                  foreign_keys: false,
-                }
-              ).connection
-
-              connection.create_table "rockets", force: true do |t|
-                t.string :name
-              end
-              connection.create_table "astronauts", force: true do |t|
-                t.string :name
-                t.references :rocket
-              end
+        unless in_memory_db?
+          def test_does_not_create_foreign_keys_when_bypassed_by_config
+            connection = ActiveRecord::Base.establish_connection(
+              {
+                adapter: "sqlite3",
+                database: "test/db/test.sqlite3",
+                foreign_keys: false,
+              }
+            ).connection
+
+            connection.create_table "rockets", force: true do |t|
+              t.string :name
+            end
+            connection.create_table "astronauts", force: true do |t|
+              t.string :name
+              t.references :rocket
+            end
 
-              connection.add_foreign_key :astronauts, :rockets
+            connection.add_foreign_key :astronauts, :rockets
 
-              foreign_keys = connection.foreign_keys("astronauts")
-              assert_equal 0, foreign_keys.size
-            ensure
-              connection.drop_table "astronauts", if_exists: true rescue nil
-              connection.drop_table "rockets", if_exists: true rescue nil
+            foreign_keys = connection.foreign_keys("astronauts")
+            assert_equal 0, foreign_keys.size
+          ensure
+            connection.drop_table "astronauts", if_exists: true rescue nil
+            connection.drop_table "rockets", if_exists: true rescue nil
 
-              ActiveRecord::Base.establish_connection(:arunit)
-            end
+            ActiveRecord::Base.establish_connection(:arunit)
           end
         end
 

activerecord/test/cases/schema_dumper_test.rb

@@ -417,12 +417,8 @@ def test_do_not_dump_foreign_keys_for_ignored_tables
       assert_equal ["authors"], output.scan(/^\s*add_foreign_key "([^"]+)".+$/).flatten
     end
 
-    def test_do_not_dump_foreign_keys_when_bypassed_by_config
-      if current_adapter?(:SQLite3Adapter) && !ActiveRecord::Base.connection.supports_concurrent_connections?
-        skip("Can't reopen in-memory database")
-      end
-
-      begin
+    unless in_memory_db?
+      def test_do_not_dump_foreign_keys_when_bypassed_by_config
         ActiveRecord::Base.establish_connection(
           {
             adapter: "sqlite3",