Skip to content

Commit 8e46af8

Browse files
authored
Merge pull request rails#51433 from ryo8000/fix-typo
Fixed typo in guides/README.md
2 parents e5d3bac + 63970d9 commit 8e46af8

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

guides/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
## About the Project
44

5-
The Rails Guides Visual Refresh occured in Q1 2024, and was intended to bring the visual style of the guides inline with the rubyonrails.org site.
5+
The Rails Guides Visual Refresh occurred in Q1 2024, and was intended to bring the visual style of the guides inline with the rubyonrails.org site.
66

7-
## Editing Depedencies
7+
## Editing Dependencies
88

99
The editing files for the Guides rebuild reside in `stylesrc` and use SCSS to improve developer experience. The code base relies on `include_media` (https://eduardoboucas.github.io/include-media/) to enable inline media-queries adjustments. We've also relied on the standard `normalize.css` (https://necolas.github.io/normalize.css/) to help bring all browsers together.
1010

@@ -16,12 +16,12 @@ To generate new guides into static files, type `rake guides:generate` from insid
1616

1717
### Why are you not using CSS variables?
1818

19-
Per the MDN documentation on CSS custom properties (https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties), they are not supported in media or container queries at this point (Feb 2024). They may in future releases, and we should pivot to that when they are more wholistically supported. SCSS variables, because they are interpolated at build, serve a similar purpose and allow us the flexibilty to support much older browsers.
19+
Per the MDN documentation on CSS custom properties (https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties), they are not supported in media or container queries at this point (Feb 2024). They may in future releases, and we should pivot to that when they are more wholistically supported. SCSS variables, because they are interpolated at build, serve a similar purpose and allow us the flexibility to support much older browsers.
2020

2121
### Why do we include LTR and RTL?
2222

2323
LTR/RTL (Left to right/right to left) is a layout change based on the nature of the language the site is being displayed in. Arabic and Farsi are two well known "RTL" languages. If the site is automatically translated, then the layout will adjust (mirror horizontally) to be more in line with the text.
2424

25-
### Why is Dark Mode in a seperate file
25+
### Why is Dark Mode in a separate file
2626

2727
IncludeMedia does not handle `prefers-color-scheme` at this time, so it was extracted.

0 commit comments

Comments
 (0)