Skip to content

Commit 8eb2c6f

Browse files
committed
Avoid a module named Namespace for Ruby 3.5
This will be a feature in Ruby 3.5 and fails: > Namespace is not a module (TypeError) Many places in rails already use `Namespaced` for this purpose. Also reported upstream: https://bugs.ruby-lang.org/issues/21341
1 parent d1baada commit 8eb2c6f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

activemodel/test/cases/validations/validates_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
require "models/person"
55
require "models/topic"
66
require "models/person_with_validator"
7-
require "validators/namespace/email_validator"
7+
require "validators/namespaced/email_validator"
88

99
class ValidatesTest < ActiveModel::TestCase
1010
setup :reset_callbacks
@@ -55,7 +55,7 @@ def test_validates_with_validator_class
5555
end
5656

5757
def test_validates_with_namespaced_validator_class
58-
Person.validates :karma, 'namespace/email': true
58+
Person.validates :karma, 'namespaced/email': true
5959
person = Person.new
6060
person.valid?
6161
assert_equal ["is not an email"], person.errors[:karma]

activemodel/test/validators/namespace/email_validator.rb renamed to activemodel/test/validators/namespaced/email_validator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
require "validators/email_validator"
44

5-
module Namespace
5+
module Namespaced
66
class EmailValidator < ::EmailValidator
77
end
88
end

0 commit comments

Comments
 (0)