Skip to content

Commit 8f9ec10

Browse files
committed
Add missing and fix incorrect version defaults
7.1 - `config.active_job.use_big_decimal_serializer` was fixed to be `true` in b4fffc3 but the documentation was not updated - `config.active_record.run_commit_callbacks_on_first_saved_instances_in_transaction` was added in 936a862 - `config.active_record.sqlite3_adapter_strict_strings_by_default` was added in 21a6dbd but the documented default is incorrect - `config.log_file_size` was initially set to `100.megabytes` but was changed during review to be `100 * 1024 * 1024` for apps using `config.active_support.bare` (cdce275) 7.0 - `config.active_support.isolation_level` was added in 540d2f4 6.1 - minor formatting fix The changes were generated by a script: https://github.com/skipkayhil/rails-bin/blob/5beae39bd83996a03b447266c43599e092a29651/bin/check-framework-defaults The parentheses around `100 * 1024 * 1024` were removed from railties/lib/rails/application/configuration.rb because the script uses the values exactly.
1 parent 0e8ee35 commit 8f9ec10

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

guides/source/configuring.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,14 @@ Below are the default values associated with each target version. In cases of co
6262

6363
- [`config.action_controller.allow_deprecated_parameters_hash_equality`](#config-action-controller-allow-deprecated-parameters-hash-equality): `false`
6464
- [`config.action_dispatch.default_headers`](#config-action-dispatch-default-headers): `{ "X-Frame-Options" => "SAMEORIGIN", "X-XSS-Protection" => "0", "X-Content-Type-Options" => "nosniff", "X-Permitted-Cross-Domain-Policies" => "none", "Referrer-Policy" => "strict-origin-when-cross-origin" }`
65-
- [`config.active_job.use_big_decimal_serializer`](#config-active-job-use-big-decimal-serializer): `false`
65+
- [`config.active_job.use_big_decimal_serializer`](#config-active-job-use-big-decimal-serializer): `true`
6666
- [`config.active_record.allow_deprecated_singular_associations_name`](#config-active-record-allow-deprecated-singular-associations-name): `false`
67-
- [`config.active_record.sqlite3_adapter_strict_strings_by_default`](#config-active-record-sqlite3-adapter-strict-strings-by-default): `false`
67+
- [`config.active_record.run_commit_callbacks_on_first_saved_instances_in_transaction`](#config-active-record-run-commit-callbacks-on-first-saved-instances-in-transaction): `false`
68+
- [`config.active_record.sqlite3_adapter_strict_strings_by_default`](#config-active-record-sqlite3-adapter-strict-strings-by-default): `true`
6869
- [`config.active_support.default_message_encryptor_serializer`](#config-active-support-default-message-encryptor-serializer): `:json`
6970
- [`config.active_support.default_message_verifier_serializer`](#config-active-support-default-message-verifier-serializer): `:json`
7071
- [`config.add_autoload_paths_to_load_path`](#config-add-autoload-paths-to-load-path): `false`
71-
- [`config.log_file_size`](#config-log-file-size): `100.megabytes`
72+
- [`config.log_file_size`](#config-log-file-size): `100 * 1024 * 1024`
7273

7374
#### Default Values for Target Version 7.0
7475

@@ -90,6 +91,7 @@ Below are the default values associated with each target version. In cases of co
9091
- [`config.active_support.disable_to_s_conversion`](#config-active-support-disable-to-s-conversion): `true`
9192
- [`config.active_support.executor_around_test_case`](#config-active-support-executor-around-test-case): `true`
9293
- [`config.active_support.hash_digest_class`](#config-active-support-hash-digest-class): `OpenSSL::Digest::SHA256`
94+
- [`config.active_support.isolation_level`](#config-active-support-isolation-level): `:thread`
9395
- [`config.active_support.key_generator_hash_digest_class`](#config-active-support-key-generator-hash-digest-class): `OpenSSL::Digest::SHA256`
9496
- [`config.active_support.remove_deprecated_time_with_zone_name`](#config-active-support-remove-deprecated-time-with-zone-name): `true`
9597
- [`config.active_support.use_rfc4122_namespaced_uuids`](#config-active-support-use-rfc4122-namespaced-uuids): `true`
@@ -98,7 +100,7 @@ Below are the default values associated with each target version. In cases of co
98100

99101
- [`ActiveSupport.utc_to_local_returns_utc_offset_times`](#activesupport-utc-to-local-returns-utc-offset-times): `true`
100102
- [`config.action_dispatch.cookies_same_site_protection`](#config-action-dispatch-cookies-same-site-protection): `:lax`
101-
- [`config.action_dispatch.ssl_default_redirect_status`](#config-action-dispatch-ssl-default-redirect-status) = `308`
103+
- [`config.action_dispatch.ssl_default_redirect_status`](#config-action-dispatch-ssl-default-redirect-status): `308`
102104
- [`config.action_mailbox.queues.incineration`](#config-action-mailbox-queues-incineration): `nil`
103105
- [`config.action_mailbox.queues.routing`](#config-action-mailbox-queues-routing): `nil`
104106
- [`config.action_mailer.deliver_later_queue_name`](#config-action-mailer-deliver-later-queue-name): `nil`

railties/lib/rails/application/configuration.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ def load_defaults(target_version)
273273
self.add_autoload_paths_to_load_path = false
274274

275275
if Rails.env.development? || Rails.env.test?
276-
self.log_file_size = (100 * 1024 * 1024)
276+
self.log_file_size = 100 * 1024 * 1024
277277
end
278278

279279
if respond_to?(:active_record)

0 commit comments

Comments
 (0)