Merge pull request rails#46658 from rails/fix-internal-metadata-connection

Fix internal_metadata connection

Author: eileencodes

activerecord/lib/active_record/migration.rb

@@ -1410,8 +1410,8 @@ def migrate_without_lock
       # Stores the current environment in the database.
       def record_environment
         return if down?
-        connection = ActiveRecord::Base.connection
-        connection.internal_metadata[:environment] = connection.migration_context.current_environment
+
+        @internal_metadata[:environment] = ActiveRecord::Base.connection.migration_context.current_environment
       end
 
       def ran?(migration)

activerecord/test/cases/multi_db_migrator_test.rb

@@ -196,6 +196,30 @@ def test_migrator_forward
     assert_equal(3, migrator_b.current_version)
   end
 
+  def test_internal_metadata_stores_environment
+    current_env     = ActiveRecord::ConnectionHandling::DEFAULT_ENV.call
+    migrations_path = MIGRATIONS_ROOT + "/valid"
+    migrator = ActiveRecord::MigrationContext.new(migrations_path, @schema_migration_b, @internal_metadata_b)
+
+    migrator.up
+    assert_equal current_env, @internal_metadata_b[:environment]
+
+    original_rails_env  = ENV["RAILS_ENV"]
+    original_rack_env   = ENV["RACK_ENV"]
+    ENV["RAILS_ENV"]    = ENV["RACK_ENV"] = "foofoo"
+    new_env = ActiveRecord::ConnectionHandling::DEFAULT_ENV.call
+
+    assert_not_equal current_env, new_env
+
+    sleep 1 # mysql by default does not store fractional seconds in the database
+    migrator.up
+    assert_equal new_env, @internal_metadata_b[:environment]
+  ensure
+    ENV["RAILS_ENV"] = original_rails_env
+    ENV["RACK_ENV"]  = original_rack_env
+    migrator.down if migrator
+  end
+
   private
     def m(name, version)
       x = Sensor.new name, version