Merge pull request rails#50241 from seanpdoyle/fieldset-tag-alias

Alias `field_set_tag` helper to `fieldset_tag`

Author: byroot

actionview/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Alias `field_set_tag` helper to `fieldset_tag` to match `<fieldset>` element
+
+    *Sean Doyle*
+
 *   Deprecate passing content to void elements when using `tag.br` type tag builders.
 
     *Hartley McGuire*

actionview/lib/action_view/helpers/form_tag_helper.rb

@@ -675,11 +675,13 @@ def image_submit_tag(source, options = {})
       #   <% end %>
       #   # => <fieldset class="format"><p><input id="name" name="name" type="text" /></p></fieldset>
       def field_set_tag(legend = nil, options = nil, &block)
-        output = tag(:fieldset, options, true)
-        output.safe_concat(content_tag("legend", legend)) unless legend.blank?
-        output.concat(capture(&block)) if block_given?
-        output.safe_concat("</fieldset>")
+        content = []
+        content << content_tag("legend", legend) unless legend.blank?
+        content << capture(&block) if block_given?
+
+        content_tag(:fieldset, safe_join(content), options)
       end
+      alias_method :fieldset_tag, :field_set_tag
 
       # Creates a text field of type "color".
       #

actionview/test/template/form_tag_helper_test.rb

@@ -925,6 +925,11 @@ def test_field_set_tag_in_erb
     expected = %(<fieldset class="format">Hello world!</fieldset>)
     assert_dom_equal expected, output_buffer
 
+    output_buffer = render_erb("<%= fieldset_tag('', :class => 'format') do %>Hello world!<% end %>")
+
+    expected = %(<fieldset class="format">Hello world!</fieldset>)
+    assert_dom_equal expected, output_buffer
+
     output_buffer = render_erb("<%= field_set_tag %>")
 
     expected = %(<fieldset></fieldset>)