File tree Expand file tree Collapse file tree 2 files changed +8
-4
lines changed Expand file tree Collapse file tree 2 files changed +8
-4
lines changed Original file line number Diff line number Diff line change @@ -184,6 +184,8 @@ def mode_from(options)
184
184
end
185
185
186
186
def log_exception ( name , e )
187
+ ActiveSupport . error_reporter . report ( e , source : name )
188
+
187
189
if logger
188
190
logger . error "Could not log #{ name . inspect } event. #{ e . class } : #{ e . message } #{ e . backtrace } "
189
191
end
Original file line number Diff line number Diff line change @@ -144,10 +144,12 @@ def test_flushes_the_same_logger_just_once
144
144
end
145
145
146
146
def test_logging_does_not_die_on_failures
147
- ActiveSupport ::LogSubscriber . attach_to :my_log_subscriber , @log_subscriber
148
- instrument "puke.my_log_subscriber"
149
- instrument "some_event.my_log_subscriber"
150
- wait
147
+ assert_error_reported do
148
+ ActiveSupport ::LogSubscriber . attach_to :my_log_subscriber , @log_subscriber
149
+ instrument "puke.my_log_subscriber"
150
+ instrument "some_event.my_log_subscriber"
151
+ wait
152
+ end
151
153
152
154
assert_equal 1 , @logger . logged ( :info ) . size
153
155
assert_equal "some_event.my_log_subscriber" , @logger . logged ( :info ) . last
You can’t perform that action at this time.
0 commit comments