Use the railties deprecator instead of creating a new one

Add tests to verify the app and helpers files deprecation / backwards
compatibility, and remove the `.rb` extension from the message, since we
generally require without them.

Author: carlosantoniodasilva

railties/lib/rails/console/app.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-ActiveSupport::Deprecation.new.warn(<<~MSG, caller_locations(0..1))
-`rails/console/app.rb` has been deprecated and will be removed in Rails 8.0.
-Please require `rails/console/methods.rb` instead.
+Rails.deprecator.warn(<<~MSG, caller_locations(0..1))
+`rails/console/app` has been deprecated and will be removed in Rails 8.0.
+Please require `rails/console/methods` instead.
 MSG
 
 require "rails/console/methods"

railties/lib/rails/console/helpers.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-ActiveSupport::Deprecation.new.warn(<<~MSG, caller_locations(0..1))
-`rails/console/helpers.rb` has been deprecated and will be removed in Rails 8.0.
-Please require `rails/console/methods.rb` instead.
+Rails.deprecator.warn(<<~MSG, caller_locations(0..1))
+`rails/console/helpers` has been deprecated and will be removed in Rails 8.0.
+Please require `rails/console/methods` instead.
 MSG
 
 require "rails/console/methods"

railties/lib/rails/console/methods.rb

@@ -13,7 +13,7 @@ def self.method_added(_method_name)
     end
 
     def self.raise_deprecation_warning
-      ActiveSupport::Deprecation.new.warn(<<~MSG, caller_locations(1..1))
+      Rails.deprecator.warn(<<~MSG, caller_locations(1..1))
         Extending Rails console through `Rails::ConsoleMethods` is deprecated and will be removed in Rails 7.3.
         Please directly use IRB's extension API to add new commands or helpers to the console.
         For more details, please visit: https://github.com/ruby/irb/blob/master/EXTEND_IRB.md

railties/test/application/console_test.rb

@@ -219,6 +219,20 @@ def foo
     write_prompt "foo", "=> \"this is foo\""
   end
 
+  def test_rails_console_app_and_helpers_files_kept_with_deprecation_for_backward_compatibility
+    add_to_config <<-RUBY
+      console do
+        require "rails/console/app"
+        require "rails/console/helpers"
+      end
+    RUBY
+
+    spawn_console("-e development", wait_for_prompt: false)
+
+    assert_output "`rails/console/app` has been deprecated", @primary, 30
+    assert_output "`rails/console/helpers` has been deprecated", @primary, 30
+  end
+
   def test_rails_console_methods_patch_backward_compatibility_with_module_reopening
     add_to_config <<-RUBY
       console do