Merge pull request rails#51348 from maxprokopiev/extract-values-check

Extract check for VALUES syntax

Author: byroot

activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb

@@ -643,7 +643,7 @@ def build_insert_sql(insert) # :nodoc:
 
         # MySQL 8.0.19 replaces `VALUES(<expression>)` clauses with row and column alias names, see https://dev.mysql.com/worklog/task/?id=6312 .
         # then MySQL 8.0.20 deprecates the `VALUES(<expression>)` see https://dev.mysql.com/worklog/task/?id=13325 .
-        if !mariadb? && database_version >= "8.0.19"
+        if supports_insert_raw_alias_syntax?
           values_alias = quote_table_name("#{insert.model.table_name}_values")
           sql = +"INSERT #{insert.into} #{insert.values_list} AS #{values_alias}"
 
@@ -894,6 +894,10 @@ def remove_index_for_alter(table_name, column_name = nil, **options)
           "DROP INDEX #{quote_column_name(index_name)}"
         end
 
+        def supports_insert_raw_alias_syntax?
+          !mariadb? && database_version >= "8.0.19"
+        end
+
         def supports_rename_index?
           if mariadb?
             database_version >= "10.5.2"