Skip to content

Commit 979e308

Browse files
committed
Don't make rdoc generation take an unreasonable amount of time
On CI, this takes about 8 hours. On my PC I canceled after 3. I suspect this comment in rdoc to be relevant (since this method is where it is stuck): https://github.com/ruby/rdoc/blob/4b846606904cc2db3999e5482c69a27f7d96947c/lib/rdoc/mixin.rb#L68-L71 Removing a few includes eventually makes it complete. It doesn't seem to matter which ones you remove. rails#52185 was the trigger for this.
1 parent de4d874 commit 979e308

File tree

1 file changed

+3
-0
lines changed
  • actionpack/lib/action_controller

1 file changed

+3
-0
lines changed

actionpack/lib/action_controller/base.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,8 @@ def self.without_modules(*modules)
266266
ParamsWrapper
267267
]
268268

269+
# Note: Documenting these severely degrates the performance of rdoc
270+
# :stopdoc:
269271
include AbstractController::Rendering
270272
include AbstractController::Translation
271273
include AbstractController::AssetPaths
@@ -309,6 +311,7 @@ def self.without_modules(*modules)
309311
# Params wrapper should come before instrumentation so they are properly showed
310312
# in logs
311313
include ParamsWrapper
314+
# :startdoc:
312315
setup_renderer!
313316

314317
# Define some internal variables that should not be propagated to the view.

0 commit comments

Comments
 (0)