Skip to content

Commit 9828cc7

Browse files
committed
Remove deprecated environment and name arguments from Tasks::DatabaseTasks.schema_up_to_date?
1 parent 515aa1e commit 9828cc7

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

activerecord/CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
* Remove deprecated `environment` and `name` arguments from `Tasks::DatabaseTasks.schema_up_to_date?`.
2+
3+
*Rafael Mendonça França*
4+
15
* Merging conditions on the same column no longer maintain both conditions,
26
and will be consistently replaced by the latter condition.
37

@@ -14,7 +18,6 @@
1418

1519
*Rafael Mendonça França*
1620

17-
1821
* Remove deprecated support to `Model.reorder(nil).first` to search using non-deterministic order.
1922

2023
*Rafael Mendonça França*

activerecord/lib/active_record/tasks/database_tasks.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -398,13 +398,9 @@ def load_schema(db_config, format = ActiveRecord.schema_format, file = nil) # :n
398398
Migration.verbose = verbose_was
399399
end
400400

401-
def schema_up_to_date?(configuration, format = ActiveRecord.schema_format, file = nil, environment = nil, name = nil)
401+
def schema_up_to_date?(configuration, format = ActiveRecord.schema_format, file = nil)
402402
db_config = resolve_configuration(configuration)
403403

404-
if environment || name
405-
ActiveSupport::Deprecation.warn("`environment` and `name` will be removed as parameters in 7.0.0, you may now pass an ActiveRecord::DatabaseConfigurations::DatabaseConfig as `configuration` instead.")
406-
end
407-
408404
file ||= schema_dump_path(db_config)
409405

410406
return true unless File.exist?(file)

guides/source/7_0_release_notes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
139139

140140
* Remove deprecated support to `Model.reorder(nil).first` to search using non-deterministic order.
141141

142+
* Remove deprecated `environment` and `name` arguments from `Tasks::DatabaseTasks.schema_up_to_date?`.
143+
142144
### Deprecations
143145

144146
### Notable changes

0 commit comments

Comments
 (0)