Allow execution wrapper to handle all exceptions

If a more serious error like SystemStackError or NoMemoryError happens,
the error reporter should be able to report these kinds of exceptions.
Some are not recoverable, but many are, so we should at least try to
report them.

Author: gmcgibbon

actionpack/lib/action_dispatch/middleware/executor.rb

@@ -21,7 +21,7 @@ def call(env)
         end
 
         returned = response << ::Rack::BodyProxy.new(response.pop) { state.complete! }
-      rescue => error
+      rescue Exception => error
         request = ActionDispatch::Request.new env
         backtrace_cleaner = request.get_header("action_dispatch.backtrace_cleaner")
         wrapper = ExceptionWrapper.new(backtrace_cleaner, error)

actionpack/test/dispatch/executor_test.rb

@@ -122,9 +122,9 @@ def test_body_abandoned
 
   def test_error_reporting
     raised_error = nil
-    error_report = assert_error_reported do
-      raised_error = assert_raises TypeError do
-        call_and_return_body { 1 + "1" }
+    error_report = assert_error_reported(Exception) do
+      raised_error = assert_raises Exception do
+        call_and_return_body { raise Exception }
       end
     end
     assert_same raised_error, error_report.error

activesupport/CHANGELOG.md

@@ -1,3 +1,12 @@
+*   Allow execution wrapping to handle all exceptions
+
+    If a more serious error like `SystemStackError` or `NoMemoryError` happens,
+    the error reporter should be able to report these kinds of exceptions.
+    Some are not recoverable, but many are, so we should at least try to
+    report them.
+
+    *Gannon McGibbon*
+
 *   `ActiveSupport::Testing::Parallelization.before_fork_hook` allows declaration of callbacks that
     are invoked immediately before forking test workers.
 

activesupport/lib/active_support/execution_wrapper.rb

@@ -89,7 +89,7 @@ def self.wrap(source: "application.active_support")
       instance = run!
       begin
         yield
-      rescue => error
+      rescue Exception => error
         error_reporter&.report(error, handled: false, source: source)
         raise
       ensure

activesupport/test/executor_test.rb

@@ -3,7 +3,7 @@
 require_relative "abstract_unit"
 
 class ExecutorTest < ActiveSupport::TestCase
-  class DummyError < RuntimeError
+  class DummyError < Exception
   end
 
   class ErrorSubscriber