Skip to content

Commit a1408e7

Browse files
authored
Merge branch 'main' into active_storage-named-variants
2 parents a1d2460 + 059024e commit a1408e7

File tree

1,394 files changed

+34418
-19130
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,394 files changed

+34418
-19130
lines changed

.github/stale.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ exemptLabels:
1010
- attached PR
1111
- regression
1212
- release blocker
13+
# Issues on a milestone will never be considered stale
14+
exemptMilestones: true
1315
# Label to use when marking an issue as stale
1416
staleLabel: stale
1517
# Comment to post when marking an issue as stale. Set to `false` to disable
@@ -18,7 +20,7 @@ markComment: >
1820
1921
The resources of the Rails team are limited, and so we are asking for your help.
2022
21-
If you can still reproduce this error on the `6-0-stable` branch or on `master`,
23+
If you can still reproduce this error on the `6-1-stable` branch or on `main`,
2224
please reply with all of the information you have about it in order to keep the issue open.
2325
2426
Thank you for all your contributions.

.github/verba-sequentur.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Documentation: https://github.com/jonathanhefner/verba-sequentur
2+
3+
"support request":
4+
comment: >
5+
This appears to be a request for technical support. We reserve the
6+
issue tracker for issues only. For technical support questions,
7+
please use the [rubyonrails-talk](https://discuss.rubyonrails.org/c/rubyonrails-talk/7)
8+
forum or [Stack Overflow](https://stackoverflow.com/questions/tagged/ruby-on-rails),
9+
where a wider community can help you.
10+
close: true
11+
12+
"feature request":
13+
comment: >
14+
This appears to be a feature request. We generally do not take
15+
feature requests, and we reserve the issue tracker for issues only.
16+
We recommend you [try to implement the feature](
17+
https://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#contributing-to-the-rails-code),
18+
and send us a pull request instead. If you are unsure if the feature
19+
would be accepted, please ask on the [rubyonrails-core](
20+
https://discuss.rubyonrails.org/c/rubyonrails-core/5) forum.
21+
close: true

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
/dist/
1111
/doc/
1212
/guides/output/
13+
Brewfile.lock.json
1314
debug.log
1415
node_modules/
1516
package-lock.json

.rubocop.yml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
require:
2+
- rubocop-packaging
23
- rubocop-performance
34
- rubocop-rails
45

@@ -7,12 +8,12 @@ AllCops:
78
# RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
89
# to ignore them, so only the ones explicitly set in this file are enabled.
910
DisabledByDefault: true
11+
SuggestExtensions: false
1012
Exclude:
1113
- '**/tmp/**/*'
1214
- '**/templates/**/*'
1315
- '**/vendor/**/*'
1416
- 'actionpack/lib/action_dispatch/journey/parser.rb'
15-
- 'railties/test/fixtures/tmp/**/*'
1617
- 'actionmailbox/test/dummy/**/*'
1718
- 'actiontext/test/dummy/**/*'
1819
- '**/node_modules/**/*'
@@ -119,6 +120,9 @@ Layout/SpaceAroundEqualsInParameterDefault:
119120
Layout/SpaceAroundKeyword:
120121
Enabled: true
121122

123+
Layout/SpaceAroundOperators:
124+
Enabled: true
125+
122126
Layout/SpaceBeforeComma:
123127
Enabled: true
124128

@@ -194,6 +198,9 @@ Lint/AmbiguousOperator:
194198
Lint/AmbiguousRegexpLiteral:
195199
Enabled: true
196200

201+
Lint/DuplicateRequire:
202+
Enabled: true
203+
197204
Lint/ErbNewArguments:
198205
Enabled: true
199206

@@ -232,6 +239,9 @@ Style/RedundantReturn:
232239
Enabled: true
233240
AllowMultipleReturnValues: true
234241

242+
Style/RedundantRegexpEscape:
243+
Enabled: true
244+
235245
Style/Semicolon:
236246
Enabled: true
237247
AllowAsExpressionSeparator: true
@@ -263,3 +273,9 @@ Performance/ReverseEach:
263273

264274
Performance/UnfreezeString:
265275
Enabled: true
276+
277+
Performance/DeletePrefix:
278+
Enabled: true
279+
280+
Performance/DeleteSuffix:
281+
Enabled: true

CONTRIBUTING.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
[![Build Status](https://badge.buildkite.com/ab1152b6a1f6a61d3ea4ec5b3eece8d4c2b830998459c75352.svg?branch=main)](https://buildkite.com/rails/rails)
2+
[![Code Triage Badge](https://www.codetriage.com/rails/rails/badges/users.svg)](https://www.codetriage.com/rails/rails)
3+
[![Version](https://img.shields.io/gem/v/rails)](https://rubygems.org/gems/rails)
4+
[![License](https://img.shields.io/github/license/rails/rails)](https://github.com/rails/rails)
5+
16
## How to contribute to Ruby on Rails
27

38
#### **Did you find a bug?**
@@ -10,9 +15,9 @@
1015
* If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/rails/rails/issues/new). Be sure to include a **title and clear description**, as much relevant information as possible, and a **code sample** or an **executable test case** demonstrating the expected behavior that is not occurring.
1116

1217
* If possible, use the relevant bug report templates to create the issue. Simply copy the content of the appropriate template into a .rb file, make the necessary changes to demonstrate the issue, and **paste the content into the issue description**:
13-
* [**Active Record** (models, database) issues](https://github.com/rails/rails/blob/master/guides/bug_report_templates/active_record_master.rb)
14-
* [**Action Pack** (controllers, routing) issues](https://github.com/rails/rails/blob/master/guides/bug_report_templates/action_controller_master.rb)
15-
* [**Generic template** for other issues](https://github.com/rails/rails/blob/master/guides/bug_report_templates/generic_master.rb)
18+
* [**Active Record** (models, database) issues](https://github.com/rails/rails/blob/main/guides/bug_report_templates/active_record_main.rb)
19+
* [**Action Pack** (controllers, routing) issues](https://github.com/rails/rails/blob/main/guides/bug_report_templates/action_controller_main.rb)
20+
* [**Generic template** for other issues](https://github.com/rails/rails/blob/main/guides/bug_report_templates/generic_main.rb)
1621

1722
* For more detailed information on submitting a bug report and creating an issue, visit our [reporting guidelines](https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#reporting-an-issue).
1823

@@ -42,7 +47,7 @@ Changes that are cosmetic in nature and do not add anything substantial to the s
4247

4348
* Please read [Contributing to the Rails Documentation](https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#contributing-to-the-rails-documentation).
4449

45-
Ruby on Rails is a volunteer effort. We encourage you to pitch in and [join the team](https://contributors.rubyonrails.org)!
50+
Ruby on Rails is a volunteer effort. We encourage you to pitch in and join [the team](https://contributors.rubyonrails.org)!
4651

4752
Thanks! :heart: :heart: :heart:
4853

Gemfile

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ gemspec
1010
gem "rake", ">= 11.1"
1111

1212
gem "capybara", ">= 3.26"
13-
gem "selenium-webdriver", ">= 3.141.592"
13+
gem "selenium-webdriver", ">= 4.0.0.alpha7"
1414

1515
gem "rack-cache", "~> 1.2"
1616
gem "sass-rails"
@@ -29,27 +29,30 @@ gem "uglifier", ">= 1.3.0", require: false
2929
gem "json", ">= 2.0.0"
3030

3131
group :rubocop do
32-
gem "rubocop", ">= 0.47", require: false
32+
gem "rubocop", ">= 0.90", require: false
33+
gem "rubocop-packaging", require: false
3334
gem "rubocop-performance", require: false
3435
gem "rubocop-rails", require: false
3536
end
3637

3738
group :doc do
38-
gem "sdoc", "~> 1.1"
39+
gem "sdoc", ">= 2.0.3"
3940
gem "redcarpet", "~> 3.2.3", platforms: :ruby
40-
gem "w3c_validators"
41+
gem "w3c_validators", "~> 1.3.6"
4142
gem "kindlerb", "~> 1.2.0"
43+
gem "rouge"
4244
end
4345

4446
# Active Support
4547
gem "dalli"
46-
gem "listen", "~> 3.2", require: false
48+
gem "listen", "~> 3.3", require: false
4749
gem "libxml-ruby", platforms: :ruby
4850
gem "connection_pool", require: false
4951
gem "rexml", require: false
5052

51-
# for railties app_generator_test
53+
# for railties
5254
gem "bootsnap", ">= 1.4.4", require: false
55+
gem "webrick", require: false
5356

5457
# Active Job
5558
group :job do
@@ -73,13 +76,9 @@ group :cable do
7376
gem "hiredis", require: false
7477
gem "redis", "~> 4.0", require: false
7578

76-
gem "redis-namespace"
79+
gem "redis-namespace", github: "resque/redis-namespace"
7780

7881
gem "websocket-client-simple", github: "matthewd/websocket-client-simple", branch: "close-race", require: false
79-
80-
gem "blade", require: false, platforms: [:ruby]
81-
gem "blade-sauce_labs_plugin", require: false, platforms: [:ruby]
82-
gem "sprockets-export", require: false
8382
end
8483

8584
# Active Storage
@@ -100,6 +99,12 @@ group :ujs do
10099
gem "webdrivers"
101100
end
102101

102+
# Action View
103+
group :view do
104+
gem "blade", require: false, platforms: [:ruby]
105+
gem "sprockets-export", require: false
106+
end
107+
103108
# Add your own local bundler stuff.
104109
local_gemfile = File.expand_path(".Gemfile", __dir__)
105110
instance_eval File.read local_gemfile if File.exist? local_gemfile
@@ -114,11 +119,11 @@ group :test do
114119
gem "byebug"
115120
end
116121

117-
gem "benchmark-ips", "< 2.8"
122+
gem "benchmark-ips"
118123
end
119124

120125
platforms :ruby, :mswin, :mswin64, :mingw, :x64_mingw do
121-
gem "nokogiri", ">= 1.8.1"
126+
gem "nokogiri", ">= 1.8.1", "!= 1.11.0"
122127

123128
# Needed for compiling the ActionDispatch::Journey parser.
124129
gem "racc", ">=1.4.6", require: false
@@ -128,7 +133,7 @@ platforms :ruby, :mswin, :mswin64, :mingw, :x64_mingw do
128133

129134
group :db do
130135
gem "pg", "~> 1.1"
131-
gem "mysql2", "~> 0.5"
136+
gem "mysql2", "~> 0.5", github: "brianmario/mysql2"
132137
end
133138
end
134139

0 commit comments

Comments
 (0)