Skip to content

Commit a2dc26e

Browse files
committed
Use PG Connection#escape over Connection.escape
Also fix AbstractMysqlAdapterTest
1 parent e28972a commit a2dc26e

File tree

3 files changed

+19
-13
lines changed

3 files changed

+19
-13
lines changed

activerecord/lib/active_record/connection_adapters/postgresql/quoting.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def quote(value) # :nodoc:
4343

4444
# Quotes strings for use in SQL input.
4545
def quote_string(s) # :nodoc:
46-
PG::Connection.escape(s)
46+
@connection.escape(s)
4747
end
4848

4949
# Checks the following cases:

activerecord/test/cases/adapters/abstract_mysql_adapter_test.rb

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,22 @@
33
require "cases/helper"
44

55
class AbstractMysqlAdapterTest < ActiveRecord::Mysql2TestCase
6-
class ExampleMysqlAdapter < ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter; end
6+
if current_adapter?(:Mysql2Adapter)
7+
class ExampleMysqlAdapter < ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter; end
78

8-
def setup
9-
@conn = ExampleMysqlAdapter.new(
10-
ActiveRecord::ConnectionAdapters::Mysql2Adapter.new_client({}),
11-
ActiveRecord::Base.logger,
12-
nil,
13-
{ socket: File::NULL }
14-
)
15-
end
9+
def setup
10+
@conn = ExampleMysqlAdapter.new(
11+
ActiveRecord::ConnectionAdapters::Mysql2Adapter.new_client({}),
12+
ActiveRecord::Base.logger,
13+
nil,
14+
{ socket: File::NULL }
15+
)
16+
end
1617

17-
def test_execute_not_raising_error
18-
assert_nothing_raised do
19-
@conn.execute("SELECT 1")
18+
def test_execute_not_raising_error
19+
assert_nothing_raised do
20+
@conn.execute("SELECT 1")
21+
end
2022
end
2123
end
2224
end

activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ def exec_params(*)
3838
{}
3939
end
4040

41+
def escape(query)
42+
PG::Connection.escape(query)
43+
end
44+
4145
def reset
4246
raise PG::ConnectionBad, "I'll be rescued by the reconnect method"
4347
end

0 commit comments

Comments
 (0)