Stop relying on mutating the configuration object

Author: rafaelfranca

actionpack/lib/action_controller/railtie.rb

@@ -27,14 +27,13 @@ class Railtie < Rails::Railtie # :nodoc:
       options = app.config.action_controller
 
       ActiveSupport.on_load(:action_controller, run_once: true) do
-        ActionController::Parameters.permit_all_parameters = options.delete(:permit_all_parameters) { false }
+        ActionController::Parameters.permit_all_parameters = options.permit_all_parameters || false
         if app.config.action_controller[:always_permitted_parameters]
           ActionController::Parameters.always_permitted_parameters =
-            app.config.action_controller.delete(:always_permitted_parameters)
+            app.config.action_controller.always_permitted_parameters
         end
-        ActionController::Parameters.action_on_unpermitted_parameters = options.delete(:action_on_unpermitted_parameters) do
+        ActionController::Parameters.action_on_unpermitted_parameters = options.action_on_unpermitted_parameters ||
           (Rails.env.test? || Rails.env.development?) ? :log : false
-        end
       end
     end
 
@@ -53,7 +52,12 @@ class Railtie < Rails::Railtie # :nodoc:
       options.relative_url_root ||= app.config.relative_url_root
 
       # Configs used in other initializers
-      options = options.except(:log_query_tags_around_actions)
+      options = options.except(
+        :log_query_tags_around_actions,
+        :permit_all_parameters,
+        :action_on_unpermitted_parameters,
+        :always_permitted_parameters
+      )
 
       ActiveSupport.on_load(:action_controller) do
         include app.routes.mounted_helpers

activejob/lib/active_job/railtie.rb

@@ -16,7 +16,7 @@ class Railtie < Rails::Railtie # :nodoc:
 
     initializer "active_job.custom_serializers" do |app|
       config.after_initialize do
-        custom_serializers = app.config.active_job.delete(:custom_serializers)
+        custom_serializers = app.config.active_job.custom_serializers
         ActiveJob::Serializers.add_serializers custom_serializers
       end
     end
@@ -26,7 +26,10 @@ class Railtie < Rails::Railtie # :nodoc:
       options.queue_adapter ||= :async
 
       # Configs used in other initializers
-      options = options.except(:log_query_tags_around_perform)
+      options = options.except(
+        :log_query_tags_around_perform,
+        :custom_serializers
+      )
 
       ActiveSupport.on_load(:active_job) do
         options.each do  |k, v|