Remove private call

Below this `private` call we only have a class definition, which as we know it
is not affected (`private` only affects methods).

We discussed with @dhh the original intention.

`ActionCable::RemoteConnections::RemoteConnection` is public interface, it is
documented in the API and it is the class of objects returned by the `where`
method. Its documentation explains which is its purpose and restricted public
interface, so we keep it public and only remove the `private` call.

Author: fxn

actioncable/lib/action_cable/remote_connections.rb

@@ -39,45 +39,44 @@ def where(identifier)
       RemoteConnection.new(server, identifier)
     end
 
-    private
-      # # Action Cable Remote Connection
-      #
-      # Represents a single remote connection found via
-      # `ActionCable.server.remote_connections.where(*)`. Exists solely for the
-      # purpose of calling #disconnect on that connection.
-      class RemoteConnection
-        class InvalidIdentifiersError < StandardError; end
+    # # Action Cable Remote Connection
+    #
+    # Represents a single remote connection found via
+    # `ActionCable.server.remote_connections.where(*)`. Exists solely for the
+    # purpose of calling #disconnect on that connection.
+    class RemoteConnection
+      class InvalidIdentifiersError < StandardError; end
 
-        include Connection::Identification, Connection::InternalChannel
+      include Connection::Identification, Connection::InternalChannel
 
-        def initialize(server, ids)
-          @server = server
-          set_identifier_instance_vars(ids)
-        end
+      def initialize(server, ids)
+        @server = server
+        set_identifier_instance_vars(ids)
+      end
 
-        # Uses the internal channel to disconnect the connection.
-        def disconnect(reconnect: true)
-          server.broadcast internal_channel, { type: "disconnect", reconnect: reconnect }
-        end
+      # Uses the internal channel to disconnect the connection.
+      def disconnect(reconnect: true)
+        server.broadcast internal_channel, { type: "disconnect", reconnect: reconnect }
+      end
 
-        # Returns all the identifiers that were applied to this connection.
-        redefine_method :identifiers do
-          server.connection_identifiers
-        end
+      # Returns all the identifiers that were applied to this connection.
+      redefine_method :identifiers do
+        server.connection_identifiers
+      end
 
-        protected
-          attr_reader :server
+      protected
+        attr_reader :server
 
-        private
-          def set_identifier_instance_vars(ids)
-            raise InvalidIdentifiersError unless valid_identifiers?(ids)
-            ids.each { |k, v| instance_variable_set("@#{k}", v) }
-          end
+      private
+        def set_identifier_instance_vars(ids)
+          raise InvalidIdentifiersError unless valid_identifiers?(ids)
+          ids.each { |k, v| instance_variable_set("@#{k}", v) }
+        end
 
-          def valid_identifiers?(ids)
-            keys = ids.keys
-            identifiers.all? { |id| keys.include?(id) }
-          end
-      end
+        def valid_identifiers?(ids)
+          keys = ids.keys
+          identifiers.all? { |id| keys.include?(id) }
+        end
+    end
   end
 end