Merge pull request rails#52907 from shioyama/shioyama/lazy_routes_recognize_path

Load routes in `LazyRoutesSet#recognize_path`

Author: gmcgibbon

railties/lib/rails/engine/lazy_route_set.rb

@@ -73,6 +73,11 @@ def draw(&block)
         super
       end
 
+      def recognize_path(path, environment = {})
+        Rails.application&.reload_routes_unless_loaded
+        super
+      end
+
       def routes
         Rails.application&.reload_routes_unless_loaded
         super

railties/test/engine/lazy_route_set_test.rb

@@ -10,6 +10,9 @@ class LazyRouteSetTest < ActiveSupport::TestCase
       setup :build_app
       teardown :teardown_app
 
+      class UsersController < ActionController::Base
+      end
+
       test "app lazily loads routes when invoking url helpers" do
         require "#{app_path}/config/environment"
 
@@ -63,11 +66,11 @@ class LazyRouteSetTest < ActiveSupport::TestCase
 
         @app = Rails.application
 
-        assert_not_operator(:users_path, :in?, app_url_helpers.methods)
-        assert_equal "/users", app_url_helpers.url_for(
-          controller: :users, action: :index, only_path: true,
+        assert_not_operator(:products_path, :in?, app_url_helpers.methods)
+        assert_equal "/products", app_url_helpers.url_for(
+          controller: :products, action: :index, only_path: true,
         )
-        assert_operator(:users_path, :in?, app_url_helpers.methods)
+        assert_operator(:products_path, :in?, app_url_helpers.methods)
       end
 
       test "engine lazily loads routes when url_for is used" do
@@ -97,6 +100,15 @@ class MyRailtie < ::Rails::Railtie
         assert_operator(Rails.application.routes, :is_a?, Engine::LazyRouteSet)
       end
 
+      test "reloads routes when recognize_path is called" do
+        require "#{app_path}/config/environment"
+
+        assert_equal(
+          { controller: "rails/engine/lazy_route_set_test/users", action: "index" },
+          Rails.application.routes.recognize_path("/users")
+        )
+      end
+
       private
         def build_app
           super
@@ -110,7 +122,8 @@ class User < ActiveRecord::Base
             Rails.application.routes.draw do
               root to: proc { [200, {}, []] }
 
-              resources(:users)
+              resources :products
+              resources :users, module: "rails/engine/lazy_route_set_test"
 
               mount Plugin::Engine, at: "/plugin"
             end