Merge pull request rails#54698 from jvlara/perf/dont-go-to-database-if-search-path-is-the-same

byroot · web-flow · commit af6bbef1df45 · 2025-03-06T15:42:50.000+01:00
perf: prevent unnecesary query on schema_search
diff --git a/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb
@@ -280,6 +280,7 @@ def drop_schema(schema_name, **options)
         #
         # This should be not be called manually but set in database.yml.
         def schema_search_path=(schema_csv)
+          return if schema_csv == @schema_search_path
           if schema_csv
             internal_execute("SET search_path TO #{schema_csv}")
             @schema_search_path = schema_csv

Original file line number	Diff line number	Diff line change
`@@ -280,6 +280,7 @@ def drop_schema(schema_name, **options)`
`280`	`280`	`#`
`281`	`281`	`# This should be not be called manually but set in database.yml.`
`282`	`282`	`def schema_search_path=(schema_csv)`
	`283`	`+ return if schema_csv == @schema_search_path`
`283`	`284`	`if schema_csv`
`284`	`285`	`internal_execute("SET search_path TO #{schema_csv}")`
`285`	`286`	`@schema_search_path = schema_csv`