Merge pull request rails#51427 from andrewn617/add-tests-for-previous-regressions

Add tests for regressions identified in rails/rails@640e3981

Author: rafaelfranca

activerecord/test/cases/table_metadata_test.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "cases/helper"
+require "models/developer"
+
+module ActiveRecord
+  class TableMetadataTest < ActiveSupport::TestCase
+    test "#associated_table creates the right type caster for joined table with different association name" do
+      base_table_metadata = TableMetadata.new(AuditRequiredDeveloper, Arel::Table.new("developers"))
+
+      associated_table_metadata = base_table_metadata.associated_table("audit_logs")
+
+      assert_equal ActiveRecord::Type::String, associated_table_metadata.arel_table.type_for_attribute(:message).class
+    end
+  end
+end

activerecord/test/cases/type_caster/connection_test.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require "cases/helper"
+require "models/developer"
+
+module ActiveRecord
+  module TypeCaster
+    class ConnectionTest < ActiveSupport::TestCase
+      test "#type_for_attribute is not aware of custom types" do
+        type_caster = Connection.new(AttributedDeveloper, "developers")
+
+        type = type_caster.type_for_attribute(:name)
+
+        assert_not_equal DeveloperName, type.class
+        assert_equal ActiveRecord::Type::String, type.class
+      end
+    end
+  end
+end

activerecord/test/models/developer.rb

@@ -372,3 +372,8 @@ class ColumnNamesCachedDeveloper < ActiveRecord::Base
   self.table_name = "developers"
   self.ignored_columns += ["name"] if column_names.include?("name")
 end
+
+class AuditRequiredDeveloper < ActiveRecord::Base
+  self.table_name = "developers"
+  has_many :required_audit_logs, class_name: "AuditLogRequired"
+end