Fix teardown callbacks (rails#50915)

* Switch ActiveSupport::TestCase teardown and setup callbacks to run in setup and teardown minitest lifecycle hooks.

Minitest provides `setup` and `teardown` lifecycle hooks to run code in. In general it is best practice to when defining your own test case class, to use `Minitest::TestCase.setup` and `Minitest::TestCase.teardown` instead of `before_setup` and `after_teardown`.

Per Minitest's Documentation on Lifecycle Hooks: https://docs.ruby-lang.org/en/2.1.0/MiniTest/Unit/LifecycleHooks.html
> before_setup()
> Runs before every test, before setup. This hook is meant for libraries to extend minitest. It is not meant to be used by test developers.

> after_teardown()
> Runs after every test, after teardown. This hook is meant for libraries to extend minitest. It is not meant to be used by test developers.

Since the `setup` and `teardown` ActiveSupport::TestCase callbacks are in essence user code, it makes sense to run during their corresponding Minitest Lifecycle hooks.

* Ensure test fixutres are torndown on errors in superclass after_teardown code.

By not adding wrapping the `teardown_fixtures` code, its possible that super raises an error and prevents the existing database transaction from rolling back.
`super` in general should only be calling `Minitest::Testcase.after_teardown` however, if another library were to override `Minitest::Testcase.after_teardown`, like the popular gem [rspec-mocks](https://github.com/rspec/rspec-mocks/blob/main/lib/rspec/mocks/minitest_integration.rb#L23) does, it causes all subsequent tests to retain any changes that were made to the database in the original test that errors.

* Remove unnecessary setup and teardown methods in tests

* update activesupport Changelog

* Fix linter issues in CHANGELOG

* fix tests with improper setup and teardown method definitions

* Fix final CHANGELOG lint

* Revert "Fix final CHANGELOG lint"

This reverts commit f30682e.

* Revert "fix tests with improper setup and teardown method definitions"

This reverts commit 1d5b88c.

* Revert "Fix linter issues in CHANGELOG"

This reverts commit 60e89bd.

* Revert "update activesupport Changelog"

This reverts commit 0f19bc3.

* Revert "Remove unnecessary setup and teardown methods in tests"

This reverts commit e5673f1.

* Revert "Switch ActiveSupport::TestCase teardown and setup callbacks to run in setup and teardown minitest lifecycle hooks."

This reverts commit d08d92d.

* Rescue Minitest::Assertion errors in ActiveSupport::TestCase.teardown callback code to ensure all other after_teardown methods are called.

* Fix name of test class

* remove unused MyError class

* Fix module to not be in global namespace

Co-authored-by: Rafael Mendonça França <[email protected]>

Author: ttstarck

activerecord/lib/active_record/test_fixtures.rb

@@ -13,6 +13,7 @@ def before_setup # :nodoc:
 
     def after_teardown # :nodoc:
       super
+    ensure
       teardown_fixtures
     end
 

activesupport/lib/active_support/testing/setup_and_teardown.rb

@@ -46,6 +46,8 @@ def after_teardown # :nodoc:
           run_callbacks :teardown
         rescue => e
           self.failures << Minitest::UnexpectedError.new(e)
+        rescue Minitest::Assertion => e
+          self.failures << e
         end
 
         super

activesupport/test/testing/after_teardown_assertion_test.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require_relative "../abstract_unit"
+
+class AfterTeardownAssertionTest < ActiveSupport::TestCase
+  module OtherAfterTeardown
+    def after_teardown
+      super
+
+      @witness = true
+    end
+  end
+  include AfterTeardownAssertionTest::OtherAfterTeardown
+
+  attr_writer :witness
+
+  teardown do
+    flunk "Test raises a Minitest::Assertion error, all after_teardown should still get called"
+  end
+
+  def after_teardown
+    assert_changes -> { failures.count }, from: 0, to: 1 do
+      super
+    end
+
+    assert_equal true, @witness
+    failures.clear
+  end
+
+  def test_teardown_raise_but_all_after_teardown_method_are_called
+    assert true
+  end
+end