Merge pull request rails#49069 from gmcgibbon/generate_correct_cpk_form_ids

Fix form_for id generation for new CPK models

Author: eileencodes

actionview/lib/action_view/record_identifier.rb

@@ -112,7 +112,7 @@ def dom_id(record_or_class, prefix = nil)
     # make sure yourself that your dom ids are valid, in case you override this method.
     def record_key_for_dom_id(record) # :doc:
       key = convert_to_model(record).to_key
-      key ? key.join(JOIN) : key
+      key && key.all? ? key.join(JOIN) : nil
     end
   end
 end

actionview/test/lib/controller/fake_models.rb

@@ -218,12 +218,27 @@ def save
   end
 end
 
-class CompositePrimaryKeyRecord
-  extend ActiveModel::Naming
-  include ActiveModel::Conversion
-  attr_reader :id
+module Cpk
+  class Book < Struct.new(:author_id, :id, :title)
+    extend ActiveModel::Naming
+    include ActiveModel::Conversion
+
+    def initialize(author_id: nil, id: nil, title: nil)
+      self.author_id = author_id
+      self.title = title
+      self.id = id
+    end
 
-  def initialize(id)
-    @id = id
+    def persisted?
+      id.all?
+    end
+
+    def id
+      [@author_id, @id]
+    end
+
+    def id=(id)
+      @author_id, @id = Array(id)
+    end
   end
 end

actionview/test/template/form_helper_test.rb

@@ -156,6 +156,10 @@ def @post.to_param; "123"; end
       end
     end
 
+    namespace(:cpk) do
+      resources(:books)
+    end
+
     get "/foo", to: "controller#action"
     root to: "main#index"
   end
@@ -4113,6 +4117,20 @@ def test_form_for_only_instantiates_builder_once
     assert_equal 1, initialization_count, "form builder instantiated more than once"
   end
 
+  def test_form_for_with_new_cpk_model
+    form_for(Cpk::Book.new) { }
+
+    expected = whole_form("/cpk/books", "new_cpk_book", "new_cpk_book", method: "post")
+    assert_dom_equal expected, @rendered
+  end
+
+  def test_form_for_with_persisted_cpk_model
+    form_for(Cpk::Book.new(id: [1, 2], title: "Some book")) { }
+
+    expected = whole_form("/cpk/books/1-2", "edit_cpk_book_1_2", "edit_cpk_book", method: "patch")
+    assert_dom_equal expected, @rendered
+  end
+
   private
     def hidden_fields(options = {})
       method = options[:method]

actionview/test/template/record_identifier_test.rb

@@ -31,8 +31,8 @@ def test_dom_id_with_saved_record
   end
 
   def test_dom_id_with_composite_primary_key_record
-    record = CompositePrimaryKeyRecord.new([1, 123])
-    assert_equal("composite_primary_key_record_1_123", dom_id(record))
+    record = Cpk::Book.new(id: [1, 123])
+    assert_equal("cpk_book_1_123", dom_id(record))
   end
 
   def test_dom_id_with_prefix