Skip to content

Commit b26a9fd

Browse files
authored
Merge pull request rails#52631 from zenspider/zenspider/minitest-cleanup
Bump minitest to 5.25.1 and clean up hacks.
2 parents 36b030d + 2650a05 commit b26a9fd

File tree

2 files changed

+3
-24
lines changed

2 files changed

+3
-24
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ GEM
347347
mini_magick (4.12.0)
348348
mini_mime (1.1.5)
349349
mini_portile2 (2.8.7)
350-
minitest (5.25.0)
350+
minitest (5.25.1)
351351
minitest-bisect (1.7.0)
352352
minitest-server (~> 1.0)
353353
path_expander (~> 1.1)

activesupport/lib/active_support/testing/parallelization/worker.rb

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -46,29 +46,8 @@ def perform_job(job)
4646

4747
set_process_title("#{klass}##{method}")
4848

49-
result = nil
50-
51-
# TODO: Remove conditional when we support on minitest 5.25+
52-
if klass.method(:with_info_handler).arity == 2
53-
t0 = nil
54-
55-
handler = lambda do
56-
unless reporter.passed? then
57-
warn "Current results:"
58-
warn reporter.reporters.grep(SummaryReporter).first
59-
end
60-
61-
warn "Current: %s#%s %.2fs" % [klass, method, Minitest.clock_time - t0]
62-
end
63-
64-
result = klass.with_info_handler reporter, handler do
65-
t0 = Minitest.clock_time
66-
Minitest.run_one_method(klass, method)
67-
end
68-
else
69-
result = klass.with_info_handler reporter do
70-
Minitest.run_one_method(klass, method)
71-
end
49+
result = klass.with_info_handler reporter do
50+
Minitest.run_one_method(klass, method)
7251
end
7352

7453
safe_record(reporter, result)

0 commit comments

Comments
 (0)