Merge pull request rails#46127 from fatkodima/fix-change_column-collation

Do not preserve original column collation in `change_column` for older migrations

Author: byroot

activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb

@@ -393,8 +393,10 @@ def build_change_column_definition(table_name, column_name, type, **options) # :
           options[:comment] = column.comment
         end
 
-        unless options.key?(:collation)
-          options[:collation] = column.collation if text_type?(type)
+        if options[:collation] == :no_collation
+          options.delete(:collation)
+        else
+          options[:collation] ||= column.collation if text_type?(type)
         end
 
         unless options.key?(:auto_increment)

activerecord/lib/active_record/migration/compatibility.rb

@@ -61,6 +61,13 @@ def rename_table(table_name, new_name, **options)
           super
         end
 
+        def change_column(table_name, column_name, type, **options)
+          if connection.adapter_name == "Mysql2"
+            options[:collation] = :no_collation
+          end
+          super
+        end
+
         def change_column_null(table_name, column_name, null, default = nil)
           super(table_name, column_name, !!null, default)
         end

activerecord/test/cases/migration/compatibility_test.rb

@@ -658,6 +658,20 @@ def up
         end
       end
 
+      if current_adapter?(:Mysql2Adapter)
+        def test_change_column_on_7_0
+          migration = Class.new(ActiveRecord::Migration[7.0]) do
+            def up
+              execute("ALTER TABLE testings CONVERT TO CHARACTER SET utf32")
+              change_column(:testings, :foo, "varchar(255) CHARACTER SET ascii")
+            end
+          end
+          assert_nothing_raised do
+            ActiveRecord::Migrator.new(:up, [migration], @schema_migration, @internal_metadata).migrate
+          end
+        end
+      end
+
       private
         def precision_implicit_default
           if current_adapter?(:Mysql2Adapter)