Merge pull request rails#43712 from Shopify/as-cache-error-handling

Report Memcached and Redis cache errors to Rails.error

Author: byroot

activesupport/lib/active_support.rb

@@ -94,6 +94,8 @@ def self.eager_load!
   cattr_accessor :test_order # :nodoc:
   cattr_accessor :test_parallelization_threshold, default: 50 # :nodoc:
 
+  singleton_class.attr_accessor :error_reporter # :nodoc:
+
   def self.cache_format_version
     Cache.format_version
   end

activesupport/lib/active_support/cache/mem_cache_store.rb

@@ -298,8 +298,9 @@ def deserialize_entry(payload, raw: false, **)
 
         def rescue_error_with(fallback)
           yield
-        rescue Dalli::DalliError => e
-          logger.error("DalliError (#{e}): #{e.message}") if logger
+        rescue Dalli::DalliError => error
+          ActiveSupport.error_reporter&.report(error, handled: true, severity: :warning)
+          logger.error("DalliError (#{error}): #{error.message}") if logger
           fallback
         end
     end

activesupport/lib/active_support/cache/redis_cache_store.rb

@@ -458,16 +458,11 @@ def serialize_entries(entries, **options)
 
         def failsafe(method, returning: nil)
           yield
-        rescue ::Redis::BaseError => e
-          handle_exception exception: e, method: method, returning: returning
+        rescue ::Redis::BaseError => error
+          ActiveSupport.error_reporter&.report(error, handled: true, severity: :warning)
+          @error_handler&.call(method: method, exception: error, returning: returning)
           returning
         end
-
-        def handle_exception(exception:, method:, returning:)
-          if @error_handler
-            @error_handler.(method: method, exception: exception, returning: returning)
-          end
-        end
     end
   end
 end

activesupport/lib/active_support/railtie.rb

@@ -112,6 +112,10 @@ class Railtie < Rails::Railtie # :nodoc:
       end
     end
 
+    initializer "active_support.set_error_reporter" do |app|
+      ActiveSupport.error_reporter = app.executor.error_reporter
+    end
+
     initializer "active_support.set_configs" do |app|
       app.config.active_support.each do |k, v|
         k = "#{k}="