Skip to content

Commit ba57ad5

Browse files
committed
Merge PR rails#42538
2 parents 4a5d8fc + fd41ea1 commit ba57ad5

File tree

16 files changed

+29
-101
lines changed

16 files changed

+29
-101
lines changed

actionmailbox/test/dummy/config/initializers/application_controller_renderer.rb

Lines changed: 0 additions & 8 deletions
This file was deleted.

actionmailbox/test/dummy/config/initializers/cookies_serializer.rb

Lines changed: 0 additions & 5 deletions
This file was deleted.

actiontext/test/dummy/config/initializers/application_controller_renderer.rb

Lines changed: 0 additions & 8 deletions
This file was deleted.

actiontext/test/dummy/config/initializers/cookies_serializer.rb

Lines changed: 0 additions & 5 deletions
This file was deleted.

activestorage/test/dummy/config/initializers/application_controller_renderer.rb

Lines changed: 0 additions & 7 deletions
This file was deleted.

activestorage/test/dummy/config/initializers/cookies_serializer.rb

Lines changed: 0 additions & 7 deletions
This file was deleted.

railties/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
* New and upgraded Rails apps no longer generate `config/initializers/application_controller_renderer.rb`
2+
or `config/initializers/cookies_serializer.rb`
3+
4+
The default value for `cookies_serializer` (`:json`) has been moved to `config.load_defaults("7.0")`.
5+
The new framework defaults file sets the serializer to `:marshal`.
6+
7+
*Alex Ghiculescu*
8+
19
* New applications get a dependency on the new `debug` gem, replacing `byebug`.
210

311
*Xavier Noria*

railties/lib/rails/application/configuration.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ def load_defaults(target_version)
199199

200200
if respond_to?(:action_dispatch)
201201
action_dispatch.return_only_request_media_type_on_content_type = false
202+
action_dispatch.cookies_serializer = :json
202203
end
203204

204205
if respond_to?(:action_controller)

railties/lib/rails/generators/rails/app/app_generator.rb

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ def config
117117
end
118118

119119
def config_when_updating
120-
cookie_serializer_config_exist = File.exist?("config/initializers/cookies_serializer.rb")
121120
action_cable_config_exist = File.exist?("config/cable.yml")
122121
active_storage_config_exist = File.exist?("config/storage.yml")
123122
rack_cors_config_exist = File.exist?("config/initializers/cors.rb")
@@ -131,10 +130,6 @@ def config_when_updating
131130

132131
config
133132

134-
unless cookie_serializer_config_exist
135-
gsub_file "config/initializers/cookies_serializer.rb", /json(?!,)/, "marshal"
136-
end
137-
138133
if !options[:skip_action_cable] && !action_cable_config_exist
139134
template "config/cable.yml"
140135
end
@@ -160,10 +155,6 @@ def config_when_updating
160155
end
161156

162157
if options[:api]
163-
unless cookie_serializer_config_exist
164-
remove_file "config/initializers/cookies_serializer.rb"
165-
end
166-
167158
unless csp_config_exist
168159
remove_file "config/initializers/content_security_policy.rb"
169160
end
@@ -487,7 +478,6 @@ def delete_action_cable_files_skipping_action_cable
487478

488479
def delete_non_api_initializers_if_api_option
489480
if options[:api]
490-
remove_file "config/initializers/cookies_serializer.rb"
491481
remove_file "config/initializers/content_security_policy.rb"
492482
remove_file "config/initializers/permissions_policy.rb"
493483
end

railties/lib/rails/generators/rails/app/templates/config/initializers/application_controller_renderer.rb.tt

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)