Merge pull request rails#53374 from rails/rm-deprecations

Remove all deprecations

Author: rafaelfranca

actionpack/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove `Rails.application.config.action_controller.allow_deprecated_parameters_hash_equality`.
+
+    *Rafael Mendonça França*
+
 *   Improve `ActionController::TestCase` to expose a binary encoded `request.body`.
 
     The rack spec clearly states:

actionpack/lib/action_controller/metal/strong_parameters.rb

@@ -261,20 +261,6 @@ class Parameters
     cattr_accessor :always_permitted_parameters, default: %w( controller action )
 
     class << self
-      def allow_deprecated_parameters_hash_equality
-        ActionController.deprecator.warn <<-WARNING.squish
-          `Rails.application.config.action_controller.allow_deprecated_parameters_hash_equality` is
-          deprecated and will be removed in Rails 8.0.
-        WARNING
-      end
-
-      def allow_deprecated_parameters_hash_equality=(value)
-        ActionController.deprecator.warn <<-WARNING.squish
-          `Rails.application.config.action_controller.allow_deprecated_parameters_hash_equality`
-          is deprecated and will be removed in Rails 8.0.
-        WARNING
-      end
-
       def nested_attribute?(key, value) # :nodoc:
         /\A-?\d+\z/.match?(key) && (value.is_a?(Hash) || value.is_a?(Parameters))
       end

actionpack/lib/action_controller/railtie.rb

@@ -48,11 +48,6 @@ class Railtie < Rails::Railtie # :nodoc:
         end
 
         ActionController::Parameters.action_on_unpermitted_parameters = action_on_unpermitted_parameters
-
-        unless options.allow_deprecated_parameters_hash_equality.nil?
-          ActionController::Parameters.allow_deprecated_parameters_hash_equality =
-            options.allow_deprecated_parameters_hash_equality
-        end
       end
     end
 
@@ -85,7 +80,6 @@ class Railtie < Rails::Railtie # :nodoc:
           :action_on_unpermitted_parameters,
           :always_permitted_parameters,
           :wrap_parameters_by_default,
-          :allow_deprecated_parameters_hash_equality
         )
 
         filtered_options.each do |k, v|

actionpack/lib/action_dispatch/routing/route_set.rb

@@ -659,14 +659,14 @@ def add_route(mapping, name)
         if route.segment_keys.include?(:controller)
           ActionDispatch.deprecator.warn(<<-MSG.squish)
             Using a dynamic :controller segment in a route is deprecated and
-            will be removed in Rails 7.2.
+            will be removed in Rails 8.1.
           MSG
         end
 
         if route.segment_keys.include?(:action)
           ActionDispatch.deprecator.warn(<<-MSG.squish)
             Using a dynamic :action segment in a route is deprecated and
-            will be removed in Rails 7.2.
+            will be removed in Rails 8.1.
           MSG
         end
 

actionview/CHANGELOG.md

@@ -1,3 +1,12 @@
+*   Remove deprecated support to passing a content to void tag elements on the `tag` builder.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to passing `nil` to the `model:` argument of `form_with`.
+
+    *Rafael Mendonça França*
+
+
 ## Rails 8.0.0.beta1 (September 26, 2024) ##
 
 *   Enable DependencyTracker to evaluate renders with trailing interpolation.

actionview/lib/action_view/helpers/form_helper.rb

@@ -754,7 +754,7 @@ def apply_form_for_options!(object, options) # :nodoc:
       #     form_with(**options.merge(builder: LabellingFormBuilder), &block)
       #   end
       def form_with(model: false, scope: nil, url: nil, format: nil, **options, &block)
-        ActionView.deprecator.warn("Passing nil to the :model argument is deprecated and will raise in Rails 8.0") if model.nil?
+        raise ArgumentError, "Passed nil to the :model argument, expect an object or false" if model.nil?
 
         options = { allow_method_names_outside_object: true, skip_default_ids: !form_with_generates_ids }.merge!(options)
 

actionview/lib/action_view/helpers/tag_helper.rb

@@ -47,16 +47,6 @@ class TagBuilder # :nodoc:
         include CaptureHelper
         include OutputSafetyHelper
 
-        def deprecated_void_content(name)
-          ActionView.deprecator.warn <<~TEXT
-            Putting content inside a void element (#{name}) is invalid
-            according to the HTML5 spec, and so it is being deprecated
-            without replacement. In Rails 8.0, passing content as a
-            positional argument will raise, and using a block will have
-            no effect.
-          TEXT
-        end
-
         def self.define_element(name, code_generator:, method_name: name)
           return if method_defined?(name)
 
@@ -71,13 +61,8 @@ def self.define_element(name, code_generator:, method_name: name)
         def self.define_void_element(name, code_generator:, method_name: name)
           code_generator.class_eval do |batch|
             batch << "\n" <<
-              "def #{method_name}(content = nil, escape: true, **options, &block)" <<
-              "  if content || block" <<
-              "    deprecated_void_content(#{name.inspect})" <<
-              "    tag_string(#{name.inspect}, content, options, escape: escape, &block)" <<
-              "  else" <<
-              "    self_closing_tag_string(#{name.inspect}, options, escape, '>')" <<
-              "  end" <<
+              "def #{method_name}(escape: true, **options, &block)" <<
+              "  self_closing_tag_string(#{name.inspect}, options, escape, '>')" <<
               "end"
           end
         end

actionview/test/template/form_helper/form_with_test.rb

@@ -340,7 +340,7 @@ def url_for(object)
   end
 
   def test_form_with_when_given_nil_model_argument
-    assert_deprecated(ActionView.deprecator) do
+    assert_raises(ArgumentError) do
       form_with(model: nil) do
       end
     end

actionview/test/template/tag_helper_test.rb

@@ -27,14 +27,14 @@ def test_tag_builder_void_tag
   end
 
   def test_tag_builder_void_tag_with_forced_content
-    assert_deprecated(ActionView.deprecator) do
-      assert_equal "<br>some content</br>", tag.br("some content")
+    assert_raises(ArgumentError) do
+      tag.br("some content")
     end
   end
 
   def test_tag_builder_void_tag_with_empty_content
-    assert_deprecated(ActionView.deprecator) do
-      assert_equal "<br></br>", tag.br("")
+    assert_raises(ArgumentError) do
+      tag.br("")
     end
   end
 

activejob/CHANGELOG.md

@@ -1,3 +1,8 @@
+*   Remove deprecated `config.active_job.use_big_decimal_serializer`.
+
+    *Rafael Mendonça França*
+
+
 ## Rails 8.0.0.beta1 (September 26, 2024) ##
 
 *   Deprecate `sucker_punch` as an adapter option.