Cleanup rails#53666

* Fix style
* Fix documentation
* Use fetch like the other methods

Author: eileencodes

activerecord/CHANGELOG.md

@@ -1,11 +1,11 @@
-*   Allow setting `schema_format` in database configuration.
+*   Allow setting the `schema_format` via database configuration.
 
     ```
     primary:
       schema_format: ruby
     ```
 
-    Useful in multi-database setups to have different formats per-database.
+    Useful for multi-database setups when apps require different formats per-database.
 
     *T S Vallender*
 

activerecord/lib/active_record/database_configurations/hash_config.rb

@@ -159,8 +159,8 @@ def schema_dump(format = schema_format)
       end
 
       def schema_format # :nodoc:
-        format = configuration_hash[:schema_format]&.to_sym || ActiveRecord.schema_format
-        raise "Invalid schema format" unless [ :ruby, :sql ].include? format
+        format = configuration_hash.fetch(:schema_format, ActiveRecord.schema_format).to_sym
+        raise "Invalid schema format" unless [:ruby, :sql].include?(format)
         format
       end
 

activerecord/lib/active_record/railties/databases.rake

@@ -459,7 +459,7 @@ db_namespace = namespace :db do
 
     namespace :dump do
       ActiveRecord::Tasks::DatabaseTasks.for_each(databases) do |name|
-        desc "Create a database schema file (either db/schema.rb or db/structure.sql, depending on `ENV['SCHEMA_FORMAT']` or `config.active_record.schema_format`) for #{name} database"
+        desc "Create a database schema file (either db/schema.rb or db/structure.sql, depending on configuration) for #{name} database"
         task name => :load_config do
           ActiveRecord::Tasks::DatabaseTasks.with_temporary_pool_for_each(name: name) do |pool|
             db_config = pool.db_config