Merge pull request rails#46566 from Shopify/logger-silence-per-logger

LoggerThreadSafeLevel only impact the receiving logger

Author: byroot

activesupport/lib/active_support/logger_thread_safe_level.rb

@@ -18,7 +18,7 @@ def #{severity.downcase}?                # def debug?
     end
 
     def local_level
-      IsolatedExecutionState[:logger_thread_safe_level]
+      IsolatedExecutionState[local_level_key]
     end
 
     def local_level=(level)
@@ -30,7 +30,11 @@ def local_level=(level)
       else
         raise ArgumentError, "Invalid log level: #{level.inspect}"
       end
-      IsolatedExecutionState[:logger_thread_safe_level] = level
+      if level.nil?
+        IsolatedExecutionState.delete(local_level_key)
+      else
+        IsolatedExecutionState[local_level_key] = level
+      end
     end
 
     def level
@@ -44,5 +48,10 @@ def log_at(level)
     ensure
       self.local_level = old_local_level
     end
+
+    private
+      def local_level_key
+        @local_level_key ||= :"logger_thread_safe_level_#{object_id}"
+      end
   end
 end

activesupport/test/logger_test.rb

@@ -392,6 +392,17 @@ def test_temporarily_logging_at_a_symbolic_level
     assert_includes @output.string, "THIS IS HERE"
   end
 
+  def test_log_at_only_impact_receiver
+    logger2 = Logger.new(StringIO.new)
+    assert_equal Logger::DEBUG, logger2.level
+    assert_equal Logger::DEBUG, @logger.level
+
+    @logger.log_at :error do
+      assert_equal Logger::DEBUG, logger2.level
+      assert_equal Logger::ERROR, @logger.level
+    end
+  end
+
   private
     def level_name(level)
       ::Logger::Severity.constants.find do |severity|