Skip to content

Commit bdbe9e0

Browse files
committed
Make ActionController::AllowBrowser::BrowserBlocker private
Despite the fact that the `BrowserBlocker` class is defined after a `private` modifier, it is still a public constant and is included in the [documentation][]. To reduce the API surface area of the `allow_browser` feature, this commit marks the class with a `# :nodoc:` comment. [documentation]: https://edgeapi.rubyonrails.org/classes/ActionController/AllowBrowser/BrowserBlocker.html
1 parent cca4db3 commit bdbe9e0

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

actionpack/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
## Rails 8.0.0.beta1 (September 26, 2024) ##
22

3+
* Make `ActionController::AllowBrowser::BrowserBlocker` private
4+
5+
*Sean Doyle*
6+
37
* Fix non-GET requests not updating cookies in `ActionController::TestCase`.
48

59
*Jon Moss*, *Hartley McGuire*

actionpack/lib/action_controller/metal/allow_browser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def allow_browser(versions:, block:)
6060
end
6161
end
6262

63-
class BrowserBlocker
63+
class BrowserBlocker # :nodoc:
6464
SETS = {
6565
modern: { safari: 17.2, chrome: 120, firefox: 121, opera: 106, ie: false }
6666
}

0 commit comments

Comments
 (0)