Merge pull request rails#55015 from skipkayhil/hm-sqlite-booleans-2

Use TRUE and FALSE for more SQLite queries

Author: byroot

activerecord/lib/active_record/connection_adapters/sqlite3/quoting.rb

@@ -80,18 +80,10 @@ def quoted_binary(value)
           "x'#{value.hex}'"
         end
 
-        def quoted_true
-          "1"
-        end
-
         def unquoted_true
           1
         end
 
-        def quoted_false
-          "0"
-        end
-
         def unquoted_false
           0
         end

activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb

@@ -564,6 +564,8 @@ def extract_value_from_default(default)
           # Binary columns
           when /x'(.*)'/
             [ $1 ].pack("H*")
+          when "TRUE", "FALSE"
+            default
           else
             # Anything else is blank or some function
             # and we can't know the value of that, so return nil.

activerecord/test/cases/adapters/sqlite3/bind_parameter_test.rb

@@ -22,7 +22,7 @@ def test_where_with_float_for_string_column_using_bind_parameters
         end
 
         def test_where_with_boolean_for_string_column_using_bind_parameters
-          assert_quoted_as "0", false
+          assert_quoted_as "FALSE", false
         end
 
         def test_where_with_decimal_for_string_column_using_bind_parameters