Skip to content

Commit c60be92

Browse files
committed
Revert "Remove unnecessary build_app calls in configuration tests"
This reverts commit 1ffef67. Those are necessary because setup calls `suppress_default_config` which moves the config/environments/* files. This is very confusing so maybe we should change the setup to not move those files.
1 parent 1ffef67 commit c60be92

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

railties/test/application/configuration_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1911,6 +1911,8 @@ def index
19111911
end
19121912

19131913
test "config.active_record.dump_schema_after_migration is false on production" do
1914+
build_app
1915+
19141916
app "production"
19151917

19161918
assert_not ActiveRecord.dump_schema_after_migration
@@ -3030,12 +3032,14 @@ class ::DummySerializer < ActiveJob::Serializers::ObjectSerializer; end
30303032
end
30313033

30323034
test "config.active_job.verbose_enqueue_logs defaults to true in development" do
3035+
build_app
30333036
app "development"
30343037

30353038
assert ActiveJob.verbose_enqueue_logs
30363039
end
30373040

30383041
test "config.active_job.verbose_enqueue_logs defaults to false in production" do
3042+
build_app
30393043
app "production"
30403044

30413045
assert_not ActiveJob.verbose_enqueue_logs

0 commit comments

Comments
 (0)