Skip to content

Commit c78af80

Browse files
authored
Merge pull request rails#55037 from Earlopain/cgi-escape-3.5
Only load from `cgi` what is required for Ruby 3.5 compatibility
2 parents f3ba830 + 18b54ea commit c78af80

File tree

11 files changed

+14
-14
lines changed

11 files changed

+14
-14
lines changed

Gemfile.lock

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ PATH
3434
actionpack (8.1.0.alpha)
3535
actionview (= 8.1.0.alpha)
3636
activesupport (= 8.1.0.alpha)
37-
cgi
3837
nokogiri (>= 1.8.5)
3938
rack (>= 2.2.4)
4039
rack-session (>= 1.0.1)
@@ -52,7 +51,6 @@ PATH
5251
actionview (8.1.0.alpha)
5352
activesupport (= 8.1.0.alpha)
5453
builder (~> 3.1)
55-
cgi
5654
erubi (~> 1.11)
5755
rails-dom-testing (~> 2.2)
5856
rails-html-sanitizer (~> 1.6)
@@ -101,7 +99,6 @@ PATH
10199
railties (8.1.0.alpha)
102100
actionpack (= 8.1.0.alpha)
103101
activesupport (= 8.1.0.alpha)
104-
cgi
105102
irb (~> 1.13)
106103
rackup (>= 1.0.0)
107104
rake (>= 12.2)
@@ -180,7 +177,6 @@ GEM
180177
rack-test (>= 0.6.3)
181178
regexp_parser (>= 1.5, < 3.0)
182179
xpath (~> 3.2)
183-
cgi (0.4.2)
184180
chef-utils (18.6.2)
185181
concurrent-ruby
186182
childprocess (5.1.0)

actionpack/actionpack.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ Gem::Specification.new do |s|
3535

3636
s.add_dependency "activesupport", version
3737

38-
s.add_dependency "cgi"
3938
s.add_dependency "nokogiri", ">= 1.8.5"
4039
s.add_dependency "rack", ">= 2.2.4"
4140
s.add_dependency "rack-session", ">= 1.0.1"

actionpack/lib/action_dispatch/journey/router.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
# :markup: markdown
44

5-
require "cgi"
5+
require "cgi/escape"
6+
require "cgi/util" if RUBY_VERSION < "3.5"
67
require "action_dispatch/journey/router/utils"
78
require "action_dispatch/journey/routes"
89
require "action_dispatch/journey/formatter"

actionview/actionview.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ Gem::Specification.new do |s|
3535

3636
s.add_dependency "activesupport", version
3737

38-
s.add_dependency "cgi"
3938
s.add_dependency "builder", "~> 3.1"
4039
s.add_dependency "erubi", "~> 1.11"
4140
s.add_dependency "rails-html-sanitizer", "~> 1.6"

actionview/lib/action_view/helpers/form_helper.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# frozen_string_literal: true
22

3-
require "cgi"
3+
require "cgi/escape"
4+
require "cgi/util" if RUBY_VERSION < "3.5"
45
require "action_view/helpers/date_helper"
56
require "action_view/helpers/url_helper"
67
require "action_view/helpers/form_tag_helper"

actionview/lib/action_view/helpers/form_options_helper.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# frozen_string_literal: true
22

3-
require "cgi"
3+
require "cgi/escape"
4+
require "cgi/util" if RUBY_VERSION < "3.5"
45
require "erb"
56
require "active_support/core_ext/string/output_safety"
67
require "active_support/core_ext/array/extract_options"

actionview/lib/action_view/helpers/form_tag_helper.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# frozen_string_literal: true
22

3-
require "cgi"
3+
require "cgi/escape"
4+
require "cgi/util" if RUBY_VERSION < "3.5"
45
require "action_view/helpers/content_exfiltration_prevention_helper"
56
require "action_view/helpers/url_helper"
67
require "action_view/helpers/text_helper"

activesupport/lib/active_support/core_ext/object/to_query.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# frozen_string_literal: true
22

3-
require "cgi"
3+
require "cgi/escape"
4+
require "cgi/util" if RUBY_VERSION < "3.5"
45

56
class Object
67
# Alias of <tt>to_s</tt>.

railties/lib/rails/info.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# frozen_string_literal: true
22

3-
require "cgi"
3+
require "cgi/escape"
4+
require "cgi/util" if RUBY_VERSION < "3.5"
45

56
module Rails
67
# This module helps build the runtime properties that are displayed in

railties/railties.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ Gem::Specification.new do |s|
4040
s.add_dependency "activesupport", version
4141
s.add_dependency "actionpack", version
4242

43-
s.add_dependency "cgi"
4443
s.add_dependency "rackup", ">= 1.0.0"
4544
s.add_dependency "rake", ">= 12.2"
4645
s.add_dependency "thor", "~> 1.0", ">= 1.2.2"

0 commit comments

Comments
 (0)