Improve concurrent unsubscribe_from_channel test

Author: byroot

actioncable/test/channel/stream_test.rb

@@ -282,9 +282,11 @@ class StreamTest < ActionCable::TestCase
     end
 
     test "concurrent unsubscribe_from_channel and stream_from do not raise RuntimeError" do
-      ENV["UNSUBSCRIBE_SLEEP_TIME"] = "0.0001" # Set a delay to increase the chance of concurrent execution
+      threads = []
       run_in_eventmachine do
         connection = TestConnection.new
+        connection.pubsub.unsubscribe_latency = 0.1
+
         channel = ChatChannel.new connection, "{id: 1}", id: 1
         channel.subscribe_to_channel
 
@@ -309,6 +311,7 @@ class StreamTest < ActionCable::TestCase
         ensure
           barrier.wait
         end
+        threads << thread1
 
         # Thread 2: calls stream_from during unsubscribe_from_channel iteration
         thread2 = Thread.new do
@@ -323,6 +326,7 @@ class StreamTest < ActionCable::TestCase
         ensure
           barrier.wait
         end
+        threads << thread2
 
         thread1.join
         thread2.join
@@ -331,7 +335,7 @@ class StreamTest < ActionCable::TestCase
         assert_nil exception_caught, "Concurrent unsubscribe_from_channel and stream_from should not raise RuntimeError: #{exception_caught}"
       end
     ensure
-      ENV.delete("UNSUBSCRIBE_SLEEP_TIME")
+      threads.each(&:kill)
     end
 
     private

actioncable/test/stubs/test_adapter.rb

@@ -1,6 +1,13 @@
 # frozen_string_literal: true
 
 class SuccessAdapter < ActionCable::SubscriptionAdapter::Base
+  attr_accessor :unsubscribe_latency
+
+  def initialize(...)
+    super
+    @unsubscribe_latency = nil
+  end
+
   def broadcast(channel, payload)
   end
 
@@ -10,7 +17,7 @@ def subscribe(channel, callback, success_callback = nil)
   end
 
   def unsubscribe(channel, callback)
-    sleep ENV["UNSUBSCRIBE_SLEEP_TIME"].to_f if ENV["UNSUBSCRIBE_SLEEP_TIME"]
+    sleep @unsubscribe_latency if @unsubscribe_latency
     subscriber_map[channel].delete(callback)
     subscriber_map.delete(channel) if subscriber_map[channel].empty?
     @@unsubscribe_called = { channel: channel, callback: callback }