Skip to content

Commit cb073d4

Browse files
committed
Fix broken test when using rails-dom-testing 2.3:
- Fix rails#55093 - The new version of dom testing now strip whitespaces when making a `text` assertion (See rails/rails-dom-testing#123). Changing to an html assertion to preserve the previous behaviour and make the test pass on rails-dom-testing 2.3
1 parent 6126662 commit cb073d4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ GEM
469469
rack (>= 1.3)
470470
rackup (2.2.1)
471471
rack (>= 3)
472-
rails-dom-testing (2.2.0)
472+
rails-dom-testing (2.3.0)
473473
activesupport (>= 5.0.0)
474474
minitest
475475
nokogiri (>= 1.6)

actionpack/test/controller/caching_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ def test_preserves_order_when_reading_from_cache_plus_rendering
414414

415415
get :index_ordered
416416
assert_equal 3, @controller.partial_rendered_times
417-
assert_select ":root", "david, 1\n david, 2\n david, 3"
417+
assert_select ":root", html: "<body><p>david, 1\n david, 2\n david, 3\n\n</p></body>"
418418
end
419419

420420
def test_explicit_render_call_with_options

0 commit comments

Comments
 (0)