Merge pull request rails#54375 from byroot/remote-on-rotate-arg

Remove `rotate(on_rotation:)` argument

Author: byroot

activesupport/lib/active_support/messages/rotator.rb

@@ -11,8 +11,7 @@ def initialize(*args, on_rotation: nil, **options)
         @on_rotation = on_rotation
       end
 
-      def rotate(*args, on_rotation: nil, **options)
-        @on_rotation = on_rotation if on_rotation
+      def rotate(*args, **options)
         fall_back_to build_rotation(*args, **options)
       end
 

activesupport/test/messages/message_rotator_tests.rb

@@ -45,15 +45,6 @@ def self.load(*); raise Class.new(StandardError); end
       assert called
     end
 
-    test "rotate(on_rotation:) is called on successful rotation" do
-      called = nil
-      codec = make_codec(secret("new")).rotate(secret("old"), on_rotation: proc { called = true })
-      old_codec = make_codec(secret("old"))
-      old_message = encode(DATA, old_codec)
-      assert_equal DATA, decode(old_message, codec)
-      assert called
-    end
-
     test "rotate().on_rotation is called on successful rotation" do
       called = nil
       codec = make_codec(secret("new")).rotate(secret("old")).on_rotation do