Merge pull request rails#55313 from joshuay03/better-index-name-length-error-message

Include current character length in index and table name length error messages

Author: yahonda

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Include current character length in error messages for index and table name length validations.
+
+    *Joshua Young*
+
 *   Add `rename_schema` method for PostgreSQL.
 
     *T S Vallender*

activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "active_support/core_ext/string/access"
+require "active_support/core_ext/string/filters"
 require "openssl"
 
 module ActiveRecord
@@ -1871,13 +1872,19 @@ def check_constraint_for!(table_name, expression: nil, **options)
 
         def validate_index_length!(table_name, new_name, internal = false)
           if new_name.length > index_name_length
-            raise ArgumentError, "Index name '#{new_name}' on table '#{table_name}' is too long; the limit is #{index_name_length} characters"
+            raise ArgumentError, <<~MSG.squish
+              Index name '#{new_name}' on table '#{table_name}' is too long (#{new_name.length} characters); the limit
+              is #{index_name_length} characters
+            MSG
           end
         end
 
         def validate_table_length!(table_name)
           if table_name.length > table_name_length
-            raise ArgumentError, "Table name '#{table_name}' is too long; the limit is #{table_name_length} characters"
+            raise ArgumentError, <<~MSG.squish
+              Table name '#{table_name}' is too long (#{table_name.length} characters); the limit is
+              #{table_name_length} characters
+            MSG
           end
         end
 

activerecord/test/cases/migration/index_test.rb

@@ -53,7 +53,7 @@ def test_rename_index_too_long
         e = assert_raises(ArgumentError) {
           connection.rename_index(table_name, "old_idx", too_long_index_name)
         }
-        assert_match(/too long; the limit is #{connection.index_name_length} characters/, e.message)
+        assert_match(/too long \(#{too_long_index_name.length} characters\); the limit is #{connection.index_name_length} characters/, e.message)
 
         assert connection.index_name_exists?(table_name, "old_idx")
       end
@@ -75,7 +75,7 @@ def test_add_index_does_not_accept_too_long_index_names
         e = assert_raises(ArgumentError) {
           connection.add_index(table_name, "foo", name: too_long_index_name)
         }
-        assert_match(/too long; the limit is #{connection.index_name_length} characters/, e.message)
+        assert_match(/too long \(#{too_long_index_name.length} characters\); the limit is #{connection.index_name_length} characters/, e.message)
 
         assert_not connection.index_name_exists?(table_name, too_long_index_name)
         connection.add_index(table_name, "foo", name: good_index_name)

activerecord/test/cases/migration/rename_table_test.rb

@@ -56,7 +56,7 @@ def test_rename_table_raises_for_long_table_names
         error = assert_raises(ArgumentError) do
           connection.rename_table :test_models, long_name
         end
-        assert_equal "Table name '#{long_name}' is too long; the limit is #{name_limit} characters", error.message
+        assert_equal "Table name '#{long_name}' is too long \(#{long_name.length} characters\); the limit is #{name_limit} characters", error.message
 
         connection.rename_table :test_models, short_name
         assert connection.table_exists?(short_name)

activerecord/test/cases/migration_test.rb

@@ -194,7 +194,7 @@ def test_create_table_raises_for_long_table_names
     error = assert_raises(ArgumentError) do
       connection.create_table(long_name)
     end
-    assert_equal "Table name '#{long_name}' is too long; the limit is #{name_limit} characters", error.message
+    assert_equal "Table name '#{long_name}' is too long \(#{long_name.length} characters\); the limit is #{name_limit} characters", error.message
 
     connection.create_table(short_name)
     assert connection.table_exists?(short_name)