Merge pull request rails#54911 from skipkayhil/hm-sqlite-booleans

Use `TRUE` and `FALSE` for booleans in SQLite

Author: kamipo

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Use `TRUE` and `FALSE` for SQLite queries with boolean columns.
+
+    *Hartley McGuire*
+
 *   Bump minimum supported SQLite to 3.23.0.
 
     *Hartley McGuire*

activerecord/lib/arel/visitors/sqlite.rb

@@ -68,14 +68,6 @@ def visit_Arel_Nodes_SelectStatement(o, collector)
           super
         end
 
-        def visit_Arel_Nodes_True(o, collector)
-          collector << "1"
-        end
-
-        def visit_Arel_Nodes_False(o, collector)
-          collector << "0"
-        end
-
         def visit_Arel_Nodes_IsNotDistinctFrom(o, collector)
           collector = visit o.left, collector
           collector << " IS "

activerecord/test/cases/arel/visitors/sqlite_test.rb

@@ -25,13 +25,6 @@ def compile(node)
         assert_equal "", @visitor.accept(node, Collectors::SQLString.new).value
       end
 
-      it "does not support boolean" do
-        node = Nodes::True.new()
-        assert_equal "1", @visitor.accept(node, Collectors::SQLString.new).value
-        node = Nodes::False.new()
-        assert_equal "0", @visitor.accept(node, Collectors::SQLString.new).value
-      end
-
       describe "Nodes::IsNotDistinctFrom" do
         it "should construct a valid generic SQL statement" do
           test = Table.new(:users)[:name].is_not_distinct_from "Aaron Patterson"