Skip to content

Commit d4de20e

Browse files
committed
Remove unused instrumentation hooks from action_controller
Instrumentation hooks for `write_page.action_controller` and `expire_page.action_controller` seem to be removed in rails#7833. So, subscribers for them are no longer necessary.
1 parent c2b083d commit d4de20e

File tree

2 files changed

+1
-26
lines changed

2 files changed

+1
-26
lines changed

actionpack/lib/action_controller/log_subscriber.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@ def unpermitted_parameters(event)
6262
end
6363
end
6464

65-
%w(write_fragment read_fragment exist_fragment?
66-
expire_fragment expire_page write_page).each do |method|
65+
%w(write_fragment read_fragment exist_fragment? expire_fragment).each do |method|
6766
class_eval <<-METHOD, __FILE__, __LINE__ + 1
6867
def #{method}(event)
6968
return unless logger.info? && ActionController::Base.enable_fragment_cache_logging

guides/source/active_support_instrumentation.md

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -156,30 +156,6 @@ Within the Ruby on Rails framework, there are a number of hooks provided for com
156156
}
157157
```
158158

159-
#### write_page.action_controller
160-
161-
| Key | Value |
162-
| ------- | ----------------- |
163-
| `:path` | The complete path |
164-
165-
```ruby
166-
{
167-
path: '/users/1'
168-
}
169-
```
170-
171-
#### expire_page.action_controller
172-
173-
| Key | Value |
174-
| ------- | ----------------- |
175-
| `:path` | The complete path |
176-
177-
```ruby
178-
{
179-
path: '/users/1'
180-
}
181-
```
182-
183159
#### start_processing.action_controller
184160

185161
| Key | Value |

0 commit comments

Comments
 (0)