Merge pull request rails#46253 from sampatbadhe/extend_reselect_with_hashes

Allow ActiveRecord::QueryMethods#reselect to accept a hash

Author: byroot

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Allow ActiveRecord::QueryMethods#reselect to receive hash values, similar to ActiveRecord::QueryMethods#select
+
+    *Sampat Badhe*
+
 *   Validate options when managing columns and tables in migrations.
 
     If an invalid option is passed to a migration method like `create_table` and `add_column`, an error will be raised

activerecord/lib/active_record/relation/query_methods.rb

@@ -406,6 +406,7 @@ def with!(*args) # :nodoc:
     # Note that we're unscoping the entire select statement.
     def reselect(*args)
       check_if_method_has_arguments!(__callee__, args)
+      args = process_select_args(args)
       spawn.reselect!(*args)
     end
 

activerecord/test/cases/relation/select_test.rb

@@ -80,6 +80,18 @@ def test_reselect_with_default_scope_select
       assert_equal expected, actual
     end
 
+    def test_reselect_with_hash_argument
+      expected = Post.select(:title, posts: { title: :post_title }).to_sql
+      actual = Post.select(:title, :body).reselect(:title, posts: { title: :post_title }).to_sql
+      assert_equal expected, actual
+    end
+
+    def test_reselect_with_one_level_hash_argument
+      expected = Post.select(:title, title: :post_title).to_sql
+      actual = Post.select(:title, :body).reselect(:title, title: :post_title).to_sql
+      assert_equal expected, actual
+    end
+
     def test_non_select_columns_wont_be_loaded
       posts = Post.select("UPPER(title) AS title")